From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjqIr-0003QZ-3R for qemu-devel@nongnu.org; Tue, 13 Sep 2016 12:11:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjqIm-00029I-UN for qemu-devel@nongnu.org; Tue, 13 Sep 2016 12:11:20 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjqIm-00028Q-PT for qemu-devel@nongnu.org; Tue, 13 Sep 2016 12:11:16 -0400 Received: by mail-wm0-f67.google.com with SMTP id c131so3675909wmh.2 for ; Tue, 13 Sep 2016 09:11:16 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Tue, 13 Sep 2016 18:10:01 +0200 Message-Id: <1473783005-113609-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1473783005-113609-1-git-send-email-pbonzini@redhat.com> References: <1473783005-113609-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 06/10] cutils: Remove ppc buffer zero checking List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: rth@twiddle.net From: Richard Henderson For ppc64le, gcc6 does extremely poorly with the Altivec code. Moreover, on POWER7 and POWER8, a hand-optimized Altivec version turns out to be no faster than the revised integer version, and therefore not worth the effort. Signed-off-by: Richard Henderson Signed-off-by: Paolo Bonzini --- util/bufferiszero.c | 26 +------------------------- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/util/bufferiszero.c b/util/bufferiszero.c index 107b0e9..de35408 100644 --- a/util/bufferiszero.c +++ b/util/bufferiszero.c @@ -94,31 +94,7 @@ buffer_zero_int(const void *buf, size_t len) } } -#if defined(__ALTIVEC__) -#include -/* The altivec.h header says we're allowed to undef these for - * C++ compatibility. Here we don't care about C++, but we - * undef them anyway to avoid namespace pollution. - * altivec.h may redefine the bool macro as vector type. - * Reset it to POSIX semantics. - */ -#undef vector -#undef pixel -#undef bool -#define bool _Bool -#define DO_NONZERO(X) vec_any_ne(X, (__vector unsigned char){ 0 }) -ACCEL_BUFFER_ZERO(buffer_zero_ppc, 128, __vector unsigned char, DO_NONZERO) - -static bool select_accel_fn(const void *buf, size_t len) -{ - uintptr_t ibuf = (uintptr_t)buf; - if (len % 128 == 0 && ibuf % sizeof(__vector unsigned char) == 0) { - return buffer_zero_ppc(buf, len); - } - return buffer_zero_int(buf, len); -} - -#elif defined(CONFIG_AVX2_OPT) || (defined(CONFIG_CPUID_H) && defined(__SSE2__)) +#if defined(CONFIG_AVX2_OPT) || (defined(CONFIG_CPUID_H) && defined(__SSE2__)) #include #pragma GCC push_options -- 1.8.3.1