From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hans Petter Selasky <hps@selasky.org>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 1/5] xhci: Fix remainder field for TR_SETUP completion event.
Date: Wed, 14 Sep 2016 11:33:31 +0200 [thread overview]
Message-ID: <1473845615-16982-2-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1473845615-16982-1-git-send-email-kraxel@redhat.com>
From: Hans Petter Selasky <hps@selasky.org>
Previously the code would incorrectly report the remainder as 8 bytes. A
remainder of 0 bytes should be reported when the SETUP packet is
successfully transferred. Found using FreeBSD's XHCI driver.
Signed-off-by: Hans Petter Selasky <hps@selasky.org>
[ kraxel: codestyle fixup ]
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/hcd-xhci.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 188f954..37c1493 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -1753,6 +1753,12 @@ static void xhci_xfer_report(XHCITransfer *xfer)
unsigned int chunk = 0;
switch (TRB_TYPE(*trb)) {
+ case TR_SETUP:
+ chunk = trb->status & 0x1ffff;
+ if (chunk > 8) {
+ chunk = 8;
+ }
+ break;
case TR_DATA:
case TR_NORMAL:
case TR_ISOCH:
--
1.8.3.1
next prev parent reply other threads:[~2016-09-14 9:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 9:33 [Qemu-devel] [PULL 0/5] usb: large file support for mtp, bugfixes Gerd Hoffmann
2016-09-14 9:33 ` Gerd Hoffmann [this message]
2016-09-14 9:33 ` [Qemu-devel] [PULL 2/5] usb-host: fix streams detection in usb_host_speed_compat Gerd Hoffmann
2016-09-14 9:33 ` [Qemu-devel] [PULL 3/5] usb:xhci:fix memory leak in usb_xhci_exit Gerd Hoffmann
2016-09-14 9:33 ` [Qemu-devel] [PULL 4/5] usb-mtp: fix sending files larger than 4gb Gerd Hoffmann
2016-09-14 9:33 ` [Qemu-devel] [PULL 5/5] usb-mtp: added object properties Gerd Hoffmann
2016-09-15 14:49 ` [Qemu-devel] [PULL 0/5] usb: large file support for mtp, bugfixes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473845615-16982-2-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=hps@selasky.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).