qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, longpeng2@huawei.com, marcel@redhat.com,
	ehabkost@redhat.com
Subject: [Qemu-devel] [PATCH 2/2] target-i386: turn off CPU.l3-cache only for 2.7 and older machine types
Date: Wed, 14 Sep 2016 12:01:50 +0200	[thread overview]
Message-ID: <1473847310-129729-3-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1473847310-129729-1-git-send-email-imammedo@redhat.com>

commit (14c985cff target-i386: present virtual L3 cache info for vcpus)
misplaced compat property putting it in new 2.8 machine type
which would effectively to disable feature until 2.9 is released.
Intent of commit probably should be to disable feature for 2.7
and older while allowing not yet released 2.8 to have feature
enabled by default.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 include/hw/i386/pc.h | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index d5654ab..1c5fd08 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -369,17 +369,16 @@ int e820_get_num_entries(void);
 bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
 
 #define PC_COMPAT_2_8 \
+
+#define PC_COMPAT_2_7 \
+    PC_COMPAT_2_8 \
+    HW_COMPAT_2_7 \
     {\
         .driver   = TYPE_X86_CPU,\
         .property = "l3-cache",\
         .value    = "off",\
     },
 
-
-#define PC_COMPAT_2_7 \
-    PC_COMPAT_2_8 \
-    HW_COMPAT_2_7
-
 #define PC_COMPAT_2_6 \
     PC_COMPAT_2_7 \
     HW_COMPAT_2_6 \
-- 
2.7.4

  parent reply	other threads:[~2016-09-14 10:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-14 10:01 [Qemu-devel] [PATCH 0/2] pc: fixes broken compat logic Igor Mammedov
2016-09-14 10:01 ` [Qemu-devel] [PATCH 1/2] pc: fix regression introduced by adding 2.8 machine Igor Mammedov
2016-09-14 11:32   ` Marcel Apfelbaum
2016-09-15 14:19   ` Eduardo Habkost
2016-09-15 15:18     ` Michael S. Tsirkin
2016-09-16  8:03       ` Igor Mammedov
2016-09-14 10:01 ` Igor Mammedov [this message]
2016-09-14 11:35   ` [Qemu-devel] [PATCH 2/2] target-i386: turn off CPU.l3-cache only for 2.7 and older machine types Marcel Apfelbaum
2016-09-15 14:23   ` Eduardo Habkost
2016-09-16  8:08     ` Igor Mammedov
2016-09-16 11:31       ` Eduardo Habkost
2016-09-18  0:28 ` [Qemu-devel] [PATCH 0/2] pc: fixes broken compat logic Longpeng (Mike)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473847310-129729-3-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=longpeng2@huawei.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).