From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkPy0-0003lJ-Ok for qemu-devel@nongnu.org; Thu, 15 Sep 2016 02:16:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkPxz-0001CU-O4 for qemu-devel@nongnu.org; Thu, 15 Sep 2016 02:16:12 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:32874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkPxz-00017x-IB for qemu-devel@nongnu.org; Thu, 15 Sep 2016 02:16:11 -0400 Received: by mail-wm0-f66.google.com with SMTP id b187so5452393wme.0 for ; Wed, 14 Sep 2016 23:15:50 -0700 (PDT) From: Dmitry Fleytman Date: Thu, 15 Sep 2016 09:14:27 +0300 Message-Id: <1473920070-21938-5-git-send-email-dmitry@daynix.com> In-Reply-To: <1473920070-21938-1-git-send-email-dmitry@daynix.com> References: <1473920070-21938-1-git-send-email-dmitry@daynix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 4/7] e1000e: Fix PBACLR implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jason Wang , Yan Vugenfirer , Shmulik Ladkani This patch fixes incorrect check for interrypt type being used. PBSCLR register is valid for MSI-X only. See spec. 10.2.3.13 MSI—X PBA Clear Signed-off-by: Dmitry Fleytman --- hw/net/e1000e_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 22765cb..c38ed10 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -2347,7 +2347,7 @@ e1000e_set_pbaclr(E1000ECore *core, int index, uint32_t val) core->mac[PBACLR] = val & E1000_PBACLR_VALID_MASK; - if (msix_enabled(core->owner)) { + if (!msix_enabled(core->owner)) { return; } -- 2.7.4