From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
Subject: [Qemu-devel] [PULL 17/17] pcspk: adding vmstate for save/restore
Date: Thu, 15 Sep 2016 16:21:56 +0200 [thread overview]
Message-ID: <1473949316-31264-18-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1473949316-31264-1-git-send-email-pbonzini@redhat.com>
From: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
VMState added by this patch preserves correct
loading of the PC speaker device state.
Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
Message-Id: <20160915090133.6440.65457.stgit@PASHA-ISP>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/audio/pcspk.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c
index 42a6f48..984534b 100644
--- a/hw/audio/pcspk.c
+++ b/hw/audio/pcspk.c
@@ -52,8 +52,8 @@ typedef struct {
unsigned int pit_count;
unsigned int samples;
unsigned int play_pos;
- int data_on;
- int dummy_refresh_clock;
+ uint8_t data_on;
+ uint8_t dummy_refresh_clock;
} PCSpkState;
static const char *s_spk = "pcspk";
@@ -187,6 +187,18 @@ static void pcspk_realizefn(DeviceState *dev, Error **errp)
pcspk_state = s;
}
+static const VMStateDescription vmstate_spk = {
+ .name = "pcspk",
+ .version_id = 1,
+ .minimum_version_id = 1,
+ .minimum_version_id_old = 1,
+ .fields = (VMStateField[]) {
+ VMSTATE_UINT8(data_on, PCSpkState),
+ VMSTATE_UINT8(dummy_refresh_clock, PCSpkState),
+ VMSTATE_END_OF_LIST()
+ }
+};
+
static Property pcspk_properties[] = {
DEFINE_PROP_UINT32("iobase", PCSpkState, iobase, -1),
DEFINE_PROP_END_OF_LIST(),
@@ -198,6 +210,7 @@ static void pcspk_class_initfn(ObjectClass *klass, void *data)
dc->realize = pcspk_realizefn;
set_bit(DEVICE_CATEGORY_SOUND, dc->categories);
+ dc->vmsd = &vmstate_spk;
dc->props = pcspk_properties;
/* Reason: realize sets global pcspk_state */
dc->cannot_instantiate_with_device_add_yet = true;
--
1.8.3.1
next prev parent reply other threads:[~2016-09-15 14:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 14:21 [Qemu-devel] [PULL 00/17] Second batch of misc patches for QEMU 2.8 Paolo Bonzini
2016-09-15 14:21 ` [Qemu-devel] [PULL 01/17] scsi-disk: Cleaning up around tray open state Paolo Bonzini
2016-09-15 14:21 ` [Qemu-devel] [PULL 02/17] virtio-scsi: Don't abort when media is ejected Paolo Bonzini
2016-09-15 14:21 ` [Qemu-devel] [PULL 03/17] scsi: mptsas: use g_new0 to allocate MPTSASRequest object Paolo Bonzini
2016-09-15 14:21 ` [Qemu-devel] [PULL 04/17] cutils: Rewrite x86 buffer zero checking Paolo Bonzini
2016-09-15 14:21 ` [Qemu-devel] [PULL 05/17] Change net/socket.c to use socket_*() functions Paolo Bonzini
2016-09-15 14:21 ` [Qemu-devel] [PULL 06/17] memory: remove memory_region_destructor_rom_device Paolo Bonzini
2016-09-15 14:21 ` [Qemu-devel] [PULL 07/17] scsi: pvscsi: limit process IO loop to ring size Paolo Bonzini
2016-09-15 14:21 ` [Qemu-devel] [PULL 08/17] pc: apic: fix touch LAPIC when irqchip is split Paolo Bonzini
2016-09-15 14:21 ` [Qemu-devel] [PULL 09/17] target-i386: fix ordering of fields in CPUX86State Paolo Bonzini
2016-09-15 14:21 ` [Qemu-devel] [PULL 10/17] linux-user: complete omission of removing uses of strdup Paolo Bonzini
2016-09-15 14:21 ` [Qemu-devel] [PULL 11/17] build-sys: add make 'help' target Paolo Bonzini
2016-09-15 14:21 ` [Qemu-devel] [PULL 12/17] qemu-char: avoid segfault if user lacks of permisson of a given logfile Paolo Bonzini
2016-09-15 14:21 ` [Qemu-devel] [PULL 13/17] log: fix parsing of multiple trace:PATTERN log args Paolo Bonzini
2016-09-15 14:21 ` [Qemu-devel] [PULL 14/17] target-i386: Fixed syscall posssible segfault Paolo Bonzini
2016-09-15 14:21 ` [Qemu-devel] [PULL 15/17] pc: apic: introduce APIC macro Paolo Bonzini
2016-09-15 14:21 ` [Qemu-devel] [PULL 16/17] kvmvapic: fix state change handler Paolo Bonzini
2016-09-15 14:21 ` Paolo Bonzini [this message]
2016-09-15 15:59 ` [Qemu-devel] [PULL 00/17] Second batch of misc patches for QEMU 2.8 no-reply
2016-09-15 18:12 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473949316-31264-18-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).