qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: qemu-trivial@nongnu.org
Cc: qemu-devel@nongnu.org, Laurent Vivier <lvivier@redhat.com>
Subject: [Qemu-devel] [PATCH 08/26] replay: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)
Date: Fri, 16 Sep 2016 15:55:59 +0200	[thread overview]
Message-ID: <1474034177-17663-9-git-send-email-lvivier@redhat.com> (raw)
In-Reply-To: <1474034177-17663-1-git-send-email-lvivier@redhat.com>

This patch is the result of coccinelle script
scripts/coccinelle/exit.cocci

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
 replay/replay-char.c     |  6 +++---
 replay/replay-events.c   |  6 +++---
 replay/replay-internal.c |  2 +-
 replay/replay-time.c     |  2 +-
 replay/replay.c          | 14 +++++++-------
 5 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/replay/replay-char.c b/replay/replay-char.c
index edf46ab..0011079 100755
--- a/replay/replay-char.c
+++ b/replay/replay-char.c
@@ -56,7 +56,7 @@ void replay_chr_be_write(CharDriverState *s, uint8_t *buf, int len)
     event->id = find_char_driver(s);
     if (event->id < 0) {
         fprintf(stderr, "Replay: cannot find char driver\n");
-        exit(1);
+        exit(EXIT_FAILURE);
     }
     event->buf = g_malloc(len);
     memcpy(event->buf, buf, len);
@@ -116,7 +116,7 @@ void replay_char_write_event_load(int *res, int *offset)
     } else {
         replay_mutex_unlock();
         error_report("Missing character write event in the replay log");
-        exit(1);
+        exit(EXIT_FAILURE);
     }
 }
 
@@ -140,7 +140,7 @@ int replay_char_read_all_load(uint8_t *buf)
     } else {
         replay_mutex_unlock();
         error_report("Missing character read all event in the replay log");
-        exit(1);
+        exit(EXIT_FAILURE);
     }
 }
 
diff --git a/replay/replay-events.c b/replay/replay-events.c
index 3807245..14a2978 100644
--- a/replay/replay-events.c
+++ b/replay/replay-events.c
@@ -57,7 +57,7 @@ static void replay_run_event(Event *event)
     default:
         error_report("Replay: invalid async event ID (%d) in the queue",
                     event->event_kind);
-        exit(1);
+        exit(EXIT_FAILURE);
         break;
     }
 }
@@ -191,7 +191,7 @@ static void replay_save_event(Event *event, int checkpoint)
             break;
         default:
             error_report("Unknown ID %" PRId64 " of replay event", event->id);
-            exit(1);
+            exit(EXIT_FAILURE);
         }
     }
 }
@@ -254,7 +254,7 @@ static Event *replay_read_event(int checkpoint)
         break;
     default:
         error_report("Unknown ID %d of replay event", read_event_kind);
-        exit(1);
+        exit(EXIT_FAILURE);
         break;
     }
 
diff --git a/replay/replay-internal.c b/replay/replay-internal.c
index 5835e8d..532323d 100644
--- a/replay/replay-internal.c
+++ b/replay/replay-internal.c
@@ -159,7 +159,7 @@ void replay_fetch_data_kind(void)
             replay_has_unread_data = 1;
             if (replay_data_kind >= EVENT_COUNT) {
                 error_report("Replay: unknown event kind %d", replay_data_kind);
-                exit(1);
+                exit(EXIT_FAILURE);
             }
         }
     }
diff --git a/replay/replay-time.c b/replay/replay-time.c
index fffe072..1741a84 100644
--- a/replay/replay-time.c
+++ b/replay/replay-time.c
@@ -61,5 +61,5 @@ int64_t replay_read_clock(ReplayClockKind kind)
     }
 
     error_report("REPLAY INTERNAL ERROR %d", __LINE__);
-    exit(1);
+    exit(EXIT_FAILURE);
 }
diff --git a/replay/replay.c b/replay/replay.c
index 167fd29..d257b24 100644
--- a/replay/replay.c
+++ b/replay/replay.c
@@ -221,7 +221,7 @@ static void replay_enable(const char *fname, int mode)
         break;
     default:
         fprintf(stderr, "Replay: internal error: invalid replay mode\n");
-        exit(1);
+        exit(EXIT_FAILURE);
     }
 
     atexit(replay_finish);
@@ -231,7 +231,7 @@ static void replay_enable(const char *fname, int mode)
     replay_file = fopen(fname, fmode);
     if (replay_file == NULL) {
         fprintf(stderr, "Replay: open %s: %s\n", fname, strerror(errno));
-        exit(1);
+        exit(EXIT_FAILURE);
     }
 
     replay_filename = g_strdup(fname);
@@ -248,7 +248,7 @@ static void replay_enable(const char *fname, int mode)
         unsigned int version = replay_get_dword();
         if (version != REPLAY_VERSION) {
             fprintf(stderr, "Replay: invalid input log file version\n");
-            exit(1);
+            exit(EXIT_FAILURE);
         }
         /* go to the beginning */
         fseek(replay_file, HEADER_SIZE, SEEK_SET);
@@ -282,13 +282,13 @@ void replay_configure(QemuOpts *opts)
         mode = REPLAY_MODE_PLAY;
     } else {
         error_report("Invalid icount rr option: %s", rr);
-        exit(1);
+        exit(EXIT_FAILURE);
     }
 
     fname = qemu_opt_get(opts, "rrfile");
     if (!fname) {
         error_report("File name not specified for replay");
-        exit(1);
+        exit(EXIT_FAILURE);
     }
 
     replay_enable(fname, mode);
@@ -305,11 +305,11 @@ void replay_start(void)
 
     if (replay_blockers) {
         error_reportf_err(replay_blockers->data, "Record/replay: ");
-        exit(1);
+        exit(EXIT_FAILURE);
     }
     if (!use_icount) {
         error_report("Please enable icount to use record/replay");
-        exit(1);
+        exit(EXIT_FAILURE);
     }
 
     /* Timer for snapshotting will be set up here. */
-- 
2.5.5

  parent reply	other threads:[~2016-09-16 13:59 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-16 13:55 [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE) Laurent Vivier
2016-09-16 13:55 ` [Qemu-devel] [PATCH 01/26] coccinelle: " Laurent Vivier
2016-09-16 15:35   ` Eric Blake
2016-09-16 13:55 ` [Qemu-devel] [PATCH 02/26] arm: " Laurent Vivier
2016-09-16 13:55 ` [Qemu-devel] [PATCH 03/26] cris: " Laurent Vivier
2016-09-16 14:41   ` Edgar E. Iglesias
2016-09-16 13:55 ` [Qemu-devel] [PATCH 04/26] block: " Laurent Vivier
2016-09-16 13:55 ` [Qemu-devel] [PATCH 05/26] ppc: " Laurent Vivier
2016-09-19  5:22   ` David Gibson
2016-09-16 13:55 ` [Qemu-devel] [PATCH 06/26] graphics: " Laurent Vivier
2016-09-16 13:55 ` [Qemu-devel] [PATCH 07/26] tests: " Laurent Vivier
2016-09-16 13:55 ` Laurent Vivier [this message]
2016-09-16 13:56 ` [Qemu-devel] [PATCH 09/26] qemu-user: " Laurent Vivier
2016-09-21 19:21   ` Riku Voipio
2016-09-16 13:56 ` [Qemu-devel] [PATCH 10/26] m68k: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-devel] [PATCH 11/26] pci, virtio: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-devel] [PATCH 12/26] sparc: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-devel] [PATCH 13/26] sh4: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-devel] [PATCH 14/26] x86: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-devel] [PATCH 15/26] mips: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-devel] [PATCH 16/26] s390: " Laurent Vivier
2016-09-19 11:07   ` Cornelia Huck
2016-09-16 13:56 ` [Qemu-devel] [PATCH 17/26] tcg: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-devel] [PATCH 18/26] posix: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-devel] [PATCH 19/26] alpha: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-devel] [PATCH 20/26] common: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-devel] [PATCH 21/26] misc machine: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-devel] [PATCH 22/26] blockdev: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-devel] [PATCH 23/26] core: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-devel] [PATCH 24/26] error, trace: " Laurent Vivier
2016-09-16 15:55   ` Eric Blake
2016-09-16 13:56 ` [Qemu-devel] [PATCH 25/26] hw: " Laurent Vivier
2016-09-16 13:56 ` [Qemu-devel] [PATCH 26/26] net: " Laurent Vivier
2016-09-16 14:41 ` [Qemu-devel] [PATCH 00/26] trivial: " no-reply
2016-09-16 14:47 ` Peter Maydell
2016-09-16 15:39   ` Daniel P. Berrange
2016-09-16 15:45     ` Peter Maydell
2016-09-19  9:21       ` Markus Armbruster
2016-09-19  9:46       ` Laurent Vivier
2016-09-19 10:19         ` Peter Maydell
2016-09-19 10:32       ` Cornelia Huck
2016-09-16 15:27 ` Daniel P. Berrange
2016-09-16 15:39   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474034177-17663-9-git-send-email-lvivier@redhat.com \
    --to=lvivier@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).