From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
lprosek@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 0/3] virtio: detach VirtQueueElements freed by reset
Date: Mon, 19 Sep 2016 14:28:02 +0100 [thread overview]
Message-ID: <1474291685-24226-1-git-send-email-stefanha@redhat.com> (raw)
virtio-blk and virtio-serial need to free VirtQueueElements during device
reset. Simply calling g_free(elem) is not enough because the scatter-gather
list should be unmapped and vq->inuse must be decremented.
These patches address the issue. I am not including a patch that changes
vq->inuse = 0 to assert(!vq->inuse) in virtio_reset() yet because virtio-9p,
virtio-gpu, and virtio-net have code paths that do not decrement vq->inuse.
Stefan Hajnoczi (3):
virtio: add virtio_detach_element()
virtio-blk: add missing virtio_detach_element() call
virtio-serial: add missing virtio_detach_element() call
hw/block/virtio-blk.c | 1 +
hw/char/virtio-serial-bus.c | 14 ++++++++++++++
hw/virtio/virtio.c | 27 +++++++++++++++++++++++++--
include/hw/virtio/virtio.h | 2 ++
4 files changed, 42 insertions(+), 2 deletions(-)
--
2.7.4
next reply other threads:[~2016-09-19 13:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 13:28 Stefan Hajnoczi [this message]
2016-09-19 13:28 ` [Qemu-devel] [PATCH 1/3] virtio: add virtio_detach_element() Stefan Hajnoczi
2016-09-26 8:43 ` Greg Kurz
2016-09-27 7:32 ` Ladi Prosek
2016-09-27 10:08 ` Stefan Hajnoczi
2016-09-27 12:12 ` Ladi Prosek
2016-09-27 15:03 ` Stefan Hajnoczi
2016-09-27 15:24 ` Ladi Prosek
2016-09-19 13:28 ` [Qemu-devel] [PATCH 2/3] virtio-blk: add missing virtio_detach_element() call Stefan Hajnoczi
2016-09-27 7:49 ` Ladi Prosek
2016-09-27 8:07 ` Greg Kurz
2016-09-19 13:28 ` [Qemu-devel] [PATCH 3/3] virtio-serial: " Stefan Hajnoczi
2016-09-30 10:08 ` Ladi Prosek
2016-09-27 10:08 ` [Qemu-devel] [PATCH 0/3] virtio: detach VirtQueueElements freed by reset Stefan Hajnoczi
2016-10-05 13:12 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474291685-24226-1-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=lprosek@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).