qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH v4 0/2] block: allow flush on devices with open tray
@ 2016-09-19 16:44 John Snow
  2016-09-19 16:44 ` [Qemu-devel] [PATCH v4 1/2] block: reintroduce bdrv_flush_all John Snow
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: John Snow @ 2016-09-19 16:44 UTC (permalink / raw)
  To: qemu-block; +Cc: kwolf, qemu-devel, qemu-stable, mreitz, John Snow

Final re-send for wording.

The move to blk_flush altered the behavior of migration and flushing
nodes that are not reachable via the guest, but are still reachable
via QEMU and may or may not need to be flushed.

This is likely the simplest solution for now until we nail down our
policy a bit more.

This is intended for 2.6.2 and/or 2.7.1, to fix problems with libvirt
et al being unable to migrate QEMU when the CDROM tray is open.

v4:
 Commit message update.

v3:
 Trying to take a hint from Kevin, reinstating bdrv_flush_all.
 If it's not what we want, we can try moving back to v2,
 acknowledging that a nicer solution in the future:
 (A) Can skip flushing on devices that just don't need it, and
 (B) Optionally institutes some sort of flush-on-eject policy.

________________________________________________________________________________

For convenience, this branch is available at:
https://github.com/jnsnow/qemu.git branch atapi-tray-migfix
https://github.com/jnsnow/qemu/tree/atapi-tray-migfix

This version is tagged atapi-tray-migfix-v4:
https://github.com/jnsnow/qemu/releases/tag/atapi-tray-migfix-v4

John Snow (2):
  block: reintroduce bdrv_flush_all
  qemu: use bdrv_flush_all for vm_stop et al

 block/io.c            | 25 +++++++++++++++++++++++++
 cpus.c                |  4 ++--
 include/block/block.h |  1 +
 3 files changed, 28 insertions(+), 2 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2016-09-20 12:16 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-19 16:44 [Qemu-devel] [PATCH v4 0/2] block: allow flush on devices with open tray John Snow
2016-09-19 16:44 ` [Qemu-devel] [PATCH v4 1/2] block: reintroduce bdrv_flush_all John Snow
2016-09-19 16:44 ` [Qemu-devel] [PATCH v4 2/2] qemu: use bdrv_flush_all for vm_stop et al John Snow
2016-09-19 18:15 ` [Qemu-devel] [PATCH v4 0/2] block: allow flush on devices with open tray no-reply
2016-09-19 19:08   ` John Snow
2016-09-19 20:58 ` Max Reitz
2016-09-19 21:21   ` John Snow
2016-09-19 21:30     ` Max Reitz
2016-09-20 12:16   ` Kevin Wolf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).