From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bm1gU-0000ZS-V3 for qemu-devel@nongnu.org; Mon, 19 Sep 2016 12:44:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bm1gQ-0000rV-3p for qemu-devel@nongnu.org; Mon, 19 Sep 2016 12:44:45 -0400 From: John Snow Date: Mon, 19 Sep 2016 12:44:31 -0400 Message-Id: <1474303471-12509-3-git-send-email-jsnow@redhat.com> In-Reply-To: <1474303471-12509-1-git-send-email-jsnow@redhat.com> References: <1474303471-12509-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PATCH v4 2/2] qemu: use bdrv_flush_all for vm_stop et al List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org, mreitz@redhat.com, John Snow Reimplement bdrv_flush_all for vm_stop. In contrast to blk_flush_all, bdrv_flush_all does not have device model restrictions. This allows us to flush and halt unconditionally without error. This allows us to do things like migrate when we have a device with an open tray, but has a node that may need to be flushed, or nodes that aren't currently attached to any device and need to be flushed. Specifically, this allows us to migrate when we have a CDROM with an open tray. Signed-off-by: John Snow Reviewed-by: Kevin Wolf --- cpus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index e39ccb7..96d9352 100644 --- a/cpus.c +++ b/cpus.c @@ -751,7 +751,7 @@ static int do_vm_stop(RunState state) } bdrv_drain_all(); - ret = blk_flush_all(); + ret = bdrv_flush_all(); return ret; } @@ -1494,7 +1494,7 @@ int vm_stop_force_state(RunState state) bdrv_drain_all(); /* Make sure to return an error if the flush in a previous vm_stop() * failed. */ - return blk_flush_all(); + return bdrv_flush_all(); } } -- 2.7.4