From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org, sw@weilnetz.de,
jcody@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com,
pbonzini@redhat.com, mreitz@redhat.com, eblake@redhat.com,
rth@twiddle.net
Subject: [Qemu-devel] [PATCH v9 05/13] vpc: Use QEMU UUID API
Date: Wed, 21 Sep 2016 12:27:18 +0800 [thread overview]
Message-ID: <1474432046-325-6-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1474432046-325-1-git-send-email-famz@redhat.com>
Previously we conditionally generated footer->uuid, when libuuid was
available. Now that we have a built-in implementation, we can switch to
it.
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
---
block/vpc.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index 43707ed..8d5886f 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -30,9 +30,7 @@
#include "qemu/module.h"
#include "migration/migration.h"
#include "qemu/bswap.h"
-#if defined(CONFIG_UUID)
-#include <uuid/uuid.h>
-#endif
+#include "qemu/uuid.h"
/**************************************************************/
@@ -89,7 +87,7 @@ typedef struct vhd_footer {
uint32_t checksum;
/* UUID used to identify a parent hard disk (backing file) */
- uint8_t uuid[16];
+ QemuUUID uuid;
uint8_t in_saved_state;
} QEMU_PACKED VHDFooter;
@@ -980,9 +978,7 @@ static int vpc_create(const char *filename, QemuOpts *opts, Error **errp)
footer->type = cpu_to_be32(disk_type);
-#if defined(CONFIG_UUID)
- uuid_generate(footer->uuid);
-#endif
+ qemu_uuid_generate(&footer->uuid);
footer->checksum = cpu_to_be32(vpc_checksum(buf, HEADER_SIZE));
--
2.7.4
next prev parent reply other threads:[~2016-09-21 4:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 4:27 [Qemu-devel] [PATCH v9 00/13] UUID clean ups for 2.8 Fam Zheng
2016-09-21 4:27 ` [Qemu-devel] [PATCH v9 01/13] util: Add UUID API Fam Zheng
2016-09-21 4:27 ` [Qemu-devel] [PATCH v9 02/13] uuid: Make null_uuid static Fam Zheng
2016-09-21 4:27 ` [Qemu-devel] [PATCH v9 03/13] vhdx: Use QEMU UUID API Fam Zheng
2016-09-21 4:27 ` [Qemu-devel] [PATCH v9 04/13] vdi: " Fam Zheng
2016-09-21 4:27 ` Fam Zheng [this message]
2016-09-21 4:27 ` [Qemu-devel] [PATCH v9 06/13] crypto: Switch to " Fam Zheng
2016-09-21 8:44 ` Daniel P. Berrange
2016-09-21 4:27 ` [Qemu-devel] [PATCH v9 07/13] tests: No longer dependent on CONFIG_UUID Fam Zheng
2016-09-21 8:45 ` Daniel P. Berrange
2016-09-21 4:27 ` [Qemu-devel] [PATCH v9 08/13] configure: Remove detection code for UUID Fam Zheng
2016-09-21 4:27 ` [Qemu-devel] [PATCH v9 09/13] vl: Switch qemu_uuid to QemuUUID Fam Zheng
2016-09-21 4:27 ` [Qemu-devel] [PATCH v9 10/13] uuid: Tighten uuid parse Fam Zheng
2016-09-21 4:27 ` [Qemu-devel] [PATCH v9 11/13] tests: Add uuid tests Fam Zheng
2016-09-21 4:27 ` [Qemu-devel] [PATCH v9 12/13] Add UUID files to MAINTAINERS Fam Zheng
2016-09-21 8:48 ` Daniel P. Berrange
2016-09-21 4:27 ` [Qemu-devel] [PATCH v9 13/13] tests: Ignore test-uuid Fam Zheng
2016-09-21 5:56 ` Jeff Cody
2016-09-21 8:49 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474432046-325-6-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).