From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmjRV-0005vp-52 for qemu-devel@nongnu.org; Wed, 21 Sep 2016 11:28:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmjRQ-0005tZ-5k for qemu-devel@nongnu.org; Wed, 21 Sep 2016 11:28:12 -0400 Received: from [62.254.189.133] (port=43003 helo=centos.localdomain) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmjRP-0005ic-R1 for qemu-devel@nongnu.org; Wed, 21 Sep 2016 11:28:08 -0400 From: Felipe Franciosi Date: Wed, 21 Sep 2016 16:27:02 +0100 Message-Id: <1474471622-12802-2-git-send-email-felipe@nutanix.com> In-Reply-To: <1474471622-12802-1-git-send-email-felipe@nutanix.com> References: <1474471622-12802-1-git-send-email-felipe@nutanix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 2/2] replay: Ignore the return value of fwrite() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , Eric Blake , "Daniel P. Berrange" Cc: Markus Armbruster , qemu-devel@nongnu.org, Felipe Franciosi If building with GCC 3.4 or newer (and using -Werror=3Dunused-result), replay-internal.c will fail to compile due to a call to fwrite() where the return value is not used. Since fwrite() is declared with WUR in glibc, callers should check the return value or find other ways to ignore it. The error message in this specific case is: replay/replay-internal.c: In function =E2=80=98replay_put_array=E2=80= =99: replay/replay-internal.c:68:15: error: ignoring return value of =E2=80=98fwrite=E2=80=99, declared with attribute warn_unused_result = [-Werror=3Dunused-result] fwrite(buf, 1, size, replay_file); ^ This commit wraps the fwrite() call with the ignore_value() macro, which currently suppresses the error for existing GCC versions. Signed-off-by: Felipe Franciosi --- replay/replay-internal. | 0 replay/replay-internal.c | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) create mode 100644 replay/replay-internal. diff --git a/replay/replay-internal. b/replay/replay-internal. new file mode 100644 index 0000000..e69de29 diff --git a/replay/replay-internal.c b/replay/replay-internal.c index 5835e8d..61de8f9 100644 --- a/replay/replay-internal.c +++ b/replay/replay-internal.c @@ -65,7 +65,7 @@ void replay_put_array(const uint8_t *buf, size_t size) { if (replay_file) { replay_put_dword(size); - fwrite(buf, 1, size, replay_file); + ignore_value(fwrite(buf, 1, size, replay_file)); } } =20 --=20 1.9.5