From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38095)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1bn1sp-0003nz-8R
	for qemu-devel@nongnu.org; Thu, 22 Sep 2016 07:09:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1bn1sk-0001BX-SB
	for qemu-devel@nongnu.org; Thu, 22 Sep 2016 07:09:38 -0400
Message-ID: <1474542549.2857.173.camel@kernel.crashing.org>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Thu, 22 Sep 2016 21:09:09 +1000
In-Reply-To: <1154052d-3aeb-3d83-f336-4f41d1d24679@ozlabs.ru>
References: <20160922052105.GD7915@in.ibm.com>
	<1474524441.2857.159.camel@kernel.crashing.org>
	<20160922061514.GF7915@in.ibm.com>
	<1474534046.2857.166.camel@kernel.crashing.org>
	<87d1jw5mr0.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me>
	<1154052d-3aeb-3d83-f336-4f41d1d24679@ozlabs.ru>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7
 broken
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>, bharata@linux.vnet.ibm.com
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, clg@kaod.org

On Thu, 2016-09-22 at 20:34 +1000, Alexey Kardashevskiy wrote:
> > diff --git a/target-ppc/machine.c b/target-ppc/machine.c
> > index 4820f22..1cf3779 100644
> > --- a/target-ppc/machine.c
> > +++ b/target-ppc/machine.c
> > @@ -563,8 +563,8 @@ const VMStateDescription vmstate_ppc_cpu =3D {
> >=C2=A0=C2=A0
> >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Sanity check=
ing */
> >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 VMSTATE_UINTTL_=
EQUAL(env.msr_mask, PowerPCCPU),
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 VMSTATE_UINT64_EQUAL(env.=
insns_flags, PowerPCCPU),
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 VMSTATE_UINT64_EQUAL(env.=
insns_flags2, PowerPCCPU),
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 VMSTATE_UNUSED(sizeof(tar=
get_ulong)), /* was
> _EQUAL(env.insns_flags) */
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 VMSTATE_UNUSED(sizeof(tar=
get_ulong)), /* was
> _EQUAL(env.insns_flags2) */
> >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 VMSTATE_UINT32_=
EQUAL(env.nb_BATs, PowerPCCPU),
> >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 VMSTATE_END_OF_=
LIST()
> >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 },
> >=C2=A0
> > TCG migration still remains broken with this.

TCG migration doesn't matter much ... yet, I think.

KVM is what actual customers use, we can probably live with some TCG
migration breakage. Hopefully we'll be done with P8 soon and it will be
stable enough, and we'll be more careful with P9.

Cheers,
Ben.