qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: rkrcmar@redhat.com, ehabkost@redhat.com, mst@redhat.com,
	kevin@koconnor.net, pbonzini@redhat.com, lersek@redhat.com,
	chao.gao@intel.com, peterx@redhat.com, liuxiaojian6@huawei.com
Subject: [Qemu-devel] [PATCH v2 13/14] pc: add 'etc/boot-cpus' fw_cfg file for machine with more than 255 CPUs
Date: Thu, 22 Sep 2016 14:50:54 +0200	[thread overview]
Message-ID: <1474548655-157373-14-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1474548655-157373-1-git-send-email-imammedo@redhat.com>

Currently firmware uses 1 byte at 0x5F offset in RTC CMOS
to get number of CPUs present at boot. However 1 byte is
not enough to handle more than 255 CPUs.  So add a new
fw_cfg file that would allow QEMU to tell it.
For compat reasons add file only for machine types that
support more than 255 CPUs.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 hw/i386/pc.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index f807932..f90db33 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1237,9 +1237,11 @@ void pc_machine_done(Notifier *notifier, void *data)
     PCMachineState *pcms = container_of(notifier,
                                         PCMachineState, machine_done);
     PCIBus *bus = pcms->bus;
+    static uint16_t boot_cpus;
 
     /* set the number of CPUs */
-    rtc_set_memory(pcms->rtc, 0x5f, pc_present_cpus_count(pcms) - 1);
+    boot_cpus = pc_present_cpus_count(pcms);
+    rtc_set_memory(pcms->rtc, 0x5f, boot_cpus - 1);
 
     if (bus) {
         int extra_hosts = 0;
@@ -1260,8 +1262,16 @@ void pc_machine_done(Notifier *notifier, void *data)
 
     acpi_setup();
     if (pcms->fw_cfg) {
+        MachineClass *mc = MACHINE_GET_CLASS(pcms);
+
         pc_build_smbios(pcms->fw_cfg);
         pc_build_feature_control_file(pcms);
+
+        if (mc->max_cpus > 255) {
+            boot_cpus = cpu_to_le16(boot_cpus);
+            fw_cfg_add_file(pcms->fw_cfg, "etc/boot-cpus", &boot_cpus,
+                            sizeof(boot_cpus));
+        }
     }
 }
 
-- 
2.7.4

  parent reply	other threads:[~2016-09-22 12:51 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-22 12:50 [Qemu-devel] [PATCH v2 00/14] pc: q35: x2APIC support in kvm_apic mode Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 01/14] numa: reduce code duplication by adding helper numa_get_node_for_cpu() Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 02/14] pc: acpi: x2APIC support for MADT table Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 03/14] pc: acpi: x2APIC support for SRAT table Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 04/14] acpi: cphp: support x2APIC entry in cpu._MAT Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 05/14] acpi: cphp: force switch to modern cpu hotplug if APIC ID > 254 Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 06/14] pc: leave max apic_id_limit only in legacy cpu hotplug code Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 07/14] pc: apic_common: extend APIC ID property to 32bit Igor Mammedov
2016-09-22 14:37   ` Paolo Bonzini
2016-09-22 16:00     ` Igor Mammedov
2016-09-22 16:16       ` Paolo Bonzini
2016-09-26 11:10         ` Igor Mammedov
2016-09-26 11:22           ` Paolo Bonzini
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 08/14] pc: apic_common: restore APIC ID to initial ID on reset Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 09/14] pc: apic_common: reset APIC ID to initial ID when switching into x2APIC mode Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 10/14] pc: kvm_apic: pass APIC ID depending on xAPIC/x2APIC mode Igor Mammedov
2016-09-22 14:36   ` Paolo Bonzini
2016-09-22 19:57     ` Radim Krčmář
2016-09-26  9:47       ` Igor Mammedov
2016-09-27 14:13         ` Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 11/14] pc: clarify FW_CFG_MAX_CPUS usage comment Igor Mammedov
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 12/14] increase MAX_CPUMASK_BITS from 255 to 288 Igor Mammedov
2016-09-22 12:50 ` Igor Mammedov [this message]
2016-09-22 12:50 ` [Qemu-devel] [PATCH v2 14/14] pc: q35: bump max_cpus " Igor Mammedov
2016-09-22 14:46 ` [Qemu-devel] [PATCH v2 00/14] pc: q35: x2APIC support in kvm_apic mode no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474548655-157373-14-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=chao.gao@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=lersek@redhat.com \
    --cc=liuxiaojian6@huawei.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).