* [Qemu-devel] [PATCH] mcf_fec: fix error in qemu_send_packet argument
@ 2016-09-22 14:28 Paolo Bonzini
2016-09-22 14:28 ` [Qemu-devel] [PATCH] imx_fec: " Paolo Bonzini
2016-09-23 5:30 ` [Qemu-devel] [PATCH] mcf_fec: " Jason Wang
0 siblings, 2 replies; 4+ messages in thread
From: Paolo Bonzini @ 2016-09-22 14:28 UTC (permalink / raw)
To: qemu-devel; +Cc: jasowang
This uses the wrong frame size for packets composed of multiple
descriptors.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/net/mcf_fec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/mcf_fec.c b/hw/net/mcf_fec.c
index 0ee8ad9..5a5fc69 100644
--- a/hw/net/mcf_fec.c
+++ b/hw/net/mcf_fec.c
@@ -176,7 +176,7 @@ static void mcf_fec_do_tx(mcf_fec_state *s)
if (bd.flags & FEC_BD_L) {
/* Last buffer in frame. */
DPRINTF("Sending packet\n");
- qemu_send_packet(qemu_get_queue(s->nic), frame, len);
+ qemu_send_packet(qemu_get_queue(s->nic), frame, frame_size);
ptr = frame;
frame_size = 0;
s->eir |= FEC_INT_TXF;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH] imx_fec: fix error in qemu_send_packet argument
2016-09-22 14:28 [Qemu-devel] [PATCH] mcf_fec: fix error in qemu_send_packet argument Paolo Bonzini
@ 2016-09-22 14:28 ` Paolo Bonzini
2016-09-23 5:32 ` Jason Wang
2016-09-23 5:30 ` [Qemu-devel] [PATCH] mcf_fec: " Jason Wang
1 sibling, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2016-09-22 14:28 UTC (permalink / raw)
To: qemu-devel; +Cc: jasowang
This uses the wrong frame size for packets composed of multiple
descriptors.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/net/imx_fec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c
index 1c415ab..50c7564 100644
--- a/hw/net/imx_fec.c
+++ b/hw/net/imx_fec.c
@@ -429,7 +429,7 @@ static void imx_fec_do_tx(IMXFECState *s)
frame_size += len;
if (bd.flags & ENET_BD_L) {
/* Last buffer in frame. */
- qemu_send_packet(qemu_get_queue(s->nic), frame, len);
+ qemu_send_packet(qemu_get_queue(s->nic), frame, frame_size);
ptr = frame;
frame_size = 0;
s->regs[ENET_EIR] |= ENET_INT_TXF;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] mcf_fec: fix error in qemu_send_packet argument
2016-09-22 14:28 [Qemu-devel] [PATCH] mcf_fec: fix error in qemu_send_packet argument Paolo Bonzini
2016-09-22 14:28 ` [Qemu-devel] [PATCH] imx_fec: " Paolo Bonzini
@ 2016-09-23 5:30 ` Jason Wang
1 sibling, 0 replies; 4+ messages in thread
From: Jason Wang @ 2016-09-23 5:30 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
On 2016年09月22日 22:28, Paolo Bonzini wrote:
> This uses the wrong frame size for packets composed of multiple
> descriptors.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/net/mcf_fec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/mcf_fec.c b/hw/net/mcf_fec.c
> index 0ee8ad9..5a5fc69 100644
> --- a/hw/net/mcf_fec.c
> +++ b/hw/net/mcf_fec.c
> @@ -176,7 +176,7 @@ static void mcf_fec_do_tx(mcf_fec_state *s)
> if (bd.flags & FEC_BD_L) {
> /* Last buffer in frame. */
> DPRINTF("Sending packet\n");
> - qemu_send_packet(qemu_get_queue(s->nic), frame, len);
> + qemu_send_packet(qemu_get_queue(s->nic), frame, frame_size);
> ptr = frame;
> frame_size = 0;
> s->eir |= FEC_INT_TXF;
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] imx_fec: fix error in qemu_send_packet argument
2016-09-22 14:28 ` [Qemu-devel] [PATCH] imx_fec: " Paolo Bonzini
@ 2016-09-23 5:32 ` Jason Wang
0 siblings, 0 replies; 4+ messages in thread
From: Jason Wang @ 2016-09-23 5:32 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
On 2016年09月22日 22:28, Paolo Bonzini wrote:
> This uses the wrong frame size for packets composed of multiple
> descriptors.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/net/imx_fec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c
> index 1c415ab..50c7564 100644
> --- a/hw/net/imx_fec.c
> +++ b/hw/net/imx_fec.c
> @@ -429,7 +429,7 @@ static void imx_fec_do_tx(IMXFECState *s)
> frame_size += len;
> if (bd.flags & ENET_BD_L) {
> /* Last buffer in frame. */
> - qemu_send_packet(qemu_get_queue(s->nic), frame, len);
> + qemu_send_packet(qemu_get_queue(s->nic), frame, frame_size);
> ptr = frame;
> frame_size = 0;
> s->regs[ENET_EIR] |= ENET_INT_TXF;
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-23 5:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-22 14:28 [Qemu-devel] [PATCH] mcf_fec: fix error in qemu_send_packet argument Paolo Bonzini
2016-09-22 14:28 ` [Qemu-devel] [PATCH] imx_fec: " Paolo Bonzini
2016-09-23 5:32 ` Jason Wang
2016-09-23 5:30 ` [Qemu-devel] [PATCH] mcf_fec: " Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).