From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn5O2-00022W-W6 for qemu-devel@nongnu.org; Thu, 22 Sep 2016 10:54:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bn5Ny-0008FZ-EL for qemu-devel@nongnu.org; Thu, 22 Sep 2016 10:54:06 -0400 Received: from mail-bn3nam01on0071.outbound.protection.outlook.com ([104.47.33.71]:7098 helo=NAM01-BN3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn5Ny-0008F8-7p for qemu-devel@nongnu.org; Thu, 22 Sep 2016 10:54:02 -0400 From: Brijesh Singh Date: Thu, 22 Sep 2016 10:53:56 -0400 Message-ID: <147455603651.8519.12363755021277774810.stgit@brijesh-build-machine> In-Reply-To: <147455590865.8519.11191009507297313736.stgit@brijesh-build-machine> References: <147455590865.8519.11191009507297313736.stgit@brijesh-build-machine> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [RFC PATCH v2 12/16] sev: add DEBUG_DECRYPT command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ehabkost@redhat.com, crosthwaite.peter@gmail.com, armbru@redhat.com, mst@redhat.com, p.fedin@samsung.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, rth@twiddle.net The command is used to decrypt a page of guest memory for debug. See docs/amd-memory-encryption.txt for command parameters detail. The command will be used by qemu monitor dump and gdbserver to access the guest memory for debug purposes. A typical usage look like: cpu_physical_memory_rw_debug cpu_physical_memory_rw_debug_internal sev_debug_decrypt Signed-off-by: Brijesh Singh --- sev.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/sev.c b/sev.c index 21c491c..c0f6ae4 100644 --- a/sev.c +++ b/sev.c @@ -1082,6 +1082,24 @@ sev_guest_launch_finish(void *handle) } static int +sev_debug_decrypt(SEVState *s, uint8_t *dst, const uint8_t *src, uint32_t len) +{ + int ret; + struct kvm_sev_dbg_decrypt *dbg; + + dbg = g_malloc0(sizeof(*dbg)); + dbg->src_addr = (unsigned long)src; + dbg->dst_addr = (unsigned long)dst; + dbg->length = len; + + ret = sev_ioctl(KVM_SEV_DBG_DECRYPT, dbg); + DPRINTF("SEV: DBG_DECRYPT src %#lx dst %#lx len %#x\n", + (uint64_t)src, (uint64_t)dst, len); + g_free(dbg); + return ret; +} + +static int sev_mem_write(uint8_t *dst, const uint8_t *src, uint32_t len, MemTxAttrs attrs) { SEVState *s = kvm_memory_encryption_get_handle(); @@ -1102,9 +1120,9 @@ sev_mem_read(uint8_t *dst, const uint8_t *src, uint32_t len, MemTxAttrs attrs) SEVState *s = kvm_memory_encryption_get_handle(); assert(s != NULL); + assert(attrs.debug || s->state != SEV_STATE_RUNNING); - // fill in the code in next patches - return 0; + return sev_debug_decrypt(s, dst, src, len); } void