From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnHTj-00057F-BO for qemu-devel@nongnu.org; Thu, 22 Sep 2016 23:48:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnHTf-0005zI-97 for qemu-devel@nongnu.org; Thu, 22 Sep 2016 23:48:46 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:35970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnHTf-0005yr-2d for qemu-devel@nongnu.org; Thu, 22 Sep 2016 23:48:43 -0400 Received: by mail-pf0-f180.google.com with SMTP id q2so37225945pfj.3 for ; Thu, 22 Sep 2016 20:48:42 -0700 (PDT) From: Wanpeng Li Date: Fri, 23 Sep 2016 11:47:36 +0800 Message-Id: <1474602456-3232-1-git-send-email-wanpeng.li@hotmail.com> Subject: [Qemu-devel] [PATCH] hmp: fix qemu crash due to ioapic state dump w/ split irqchip List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kvm@vger.kernel.org, qemu-devel@nongnu.org Cc: Wanpeng Li , Paolo Bonzini , Richard Henderson , Eduardo Habkost From: Wanpeng Li The qemu will crash when info ioapic through hmp if irqchip is split. Below message is splat: KVM_GET_IRQCHIP failed: Unknown error -6 This patch fix it by dumping the ioapic state from the qemu emulated ioapic if irqchip is split. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Wanpeng Li --- target-i386/monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target-i386/monitor.c b/target-i386/monitor.c index fccfe40..bf1e983 100644 --- a/target-i386/monitor.c +++ b/target-i386/monitor.c @@ -504,7 +504,8 @@ void hmp_info_local_apic(Monitor *mon, const QDict *qdict) void hmp_info_io_apic(Monitor *mon, const QDict *qdict) { - if (kvm_irqchip_in_kernel()) { + if (kvm_irqchip_in_kernel() && + !kvm_irqchip_is_split()) { kvm_ioapic_dump_state(mon, qdict); } else { ioapic_dump_state(mon, qdict); -- 1.9.1