* [Qemu-devel] [PATCH] hmp: fix qemu crash due to ioapic state dump w/ split irqchip
@ 2016-09-23 3:47 Wanpeng Li
2016-09-23 9:08 ` Peter Xu
2016-09-26 8:23 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Wanpeng Li @ 2016-09-23 3:47 UTC (permalink / raw)
To: kvm, qemu-devel
Cc: Wanpeng Li, Paolo Bonzini, Richard Henderson, Eduardo Habkost
From: Wanpeng Li <wanpeng.li@hotmail.com>
The qemu will crash when info ioapic through hmp if irqchip
is split. Below message is splat:
KVM_GET_IRQCHIP failed: Unknown error -6
This patch fix it by dumping the ioapic state from the qemu
emulated ioapic if irqchip is split.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
---
target-i386/monitor.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target-i386/monitor.c b/target-i386/monitor.c
index fccfe40..bf1e983 100644
--- a/target-i386/monitor.c
+++ b/target-i386/monitor.c
@@ -504,7 +504,8 @@ void hmp_info_local_apic(Monitor *mon, const QDict *qdict)
void hmp_info_io_apic(Monitor *mon, const QDict *qdict)
{
- if (kvm_irqchip_in_kernel()) {
+ if (kvm_irqchip_in_kernel() &&
+ !kvm_irqchip_is_split()) {
kvm_ioapic_dump_state(mon, qdict);
} else {
ioapic_dump_state(mon, qdict);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] hmp: fix qemu crash due to ioapic state dump w/ split irqchip
2016-09-23 3:47 [Qemu-devel] [PATCH] hmp: fix qemu crash due to ioapic state dump w/ split irqchip Wanpeng Li
@ 2016-09-23 9:08 ` Peter Xu
2016-09-26 8:23 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Peter Xu @ 2016-09-23 9:08 UTC (permalink / raw)
To: Wanpeng Li
Cc: kvm, qemu-devel, Paolo Bonzini, Eduardo Habkost, Wanpeng Li,
Richard Henderson
On Fri, Sep 23, 2016 at 11:47:36AM +0800, Wanpeng Li wrote:
> From: Wanpeng Li <wanpeng.li@hotmail.com>
>
> The qemu will crash when info ioapic through hmp if irqchip
> is split. Below message is splat:
>
> KVM_GET_IRQCHIP failed: Unknown error -6
>
> This patch fix it by dumping the ioapic state from the qemu
> emulated ioapic if irqchip is split.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hmp: fix qemu crash due to ioapic state dump w/ split irqchip
2016-09-23 3:47 [Qemu-devel] [PATCH] hmp: fix qemu crash due to ioapic state dump w/ split irqchip Wanpeng Li
2016-09-23 9:08 ` Peter Xu
@ 2016-09-26 8:23 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2016-09-26 8:23 UTC (permalink / raw)
To: Wanpeng Li, kvm, qemu-devel
Cc: Wanpeng Li, Richard Henderson, Eduardo Habkost
On 23/09/2016 05:47, Wanpeng Li wrote:
> From: Wanpeng Li <wanpeng.li@hotmail.com>
>
> The qemu will crash when info ioapic through hmp if irqchip
> is split. Below message is splat:
>
> KVM_GET_IRQCHIP failed: Unknown error -6
>
> This patch fix it by dumping the ioapic state from the qemu
> emulated ioapic if irqchip is split.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
> ---
> target-i386/monitor.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target-i386/monitor.c b/target-i386/monitor.c
> index fccfe40..bf1e983 100644
> --- a/target-i386/monitor.c
> +++ b/target-i386/monitor.c
> @@ -504,7 +504,8 @@ void hmp_info_local_apic(Monitor *mon, const QDict *qdict)
>
> void hmp_info_io_apic(Monitor *mon, const QDict *qdict)
> {
> - if (kvm_irqchip_in_kernel()) {
> + if (kvm_irqchip_in_kernel() &&
> + !kvm_irqchip_is_split()) {
> kvm_ioapic_dump_state(mon, qdict);
> } else {
> ioapic_dump_state(mon, qdict);
>
Queued, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-26 8:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-23 3:47 [Qemu-devel] [PATCH] hmp: fix qemu crash due to ioapic state dump w/ split irqchip Wanpeng Li
2016-09-23 9:08 ` Peter Xu
2016-09-26 8:23 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).