From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnJ6z-0006Gc-37 for qemu-devel@nongnu.org; Fri, 23 Sep 2016 01:33:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnJ6x-0006V1-4V for qemu-devel@nongnu.org; Fri, 23 Sep 2016 01:33:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnJ6w-0006Us-VH for qemu-devel@nongnu.org; Fri, 23 Sep 2016 01:33:23 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7C53D7F7BD for ; Fri, 23 Sep 2016 05:33:22 +0000 (UTC) From: Peter Xu Date: Fri, 23 Sep 2016 13:33:15 +0800 Message-Id: <1474608795-23058-1-git-send-email-peterx@redhat.com> Subject: [Qemu-devel] [PATCH v2] x86: ioapic: boost default version to 0x20 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, imammedo@redhat.com, peterx@redhat.com It's 2.8 now, and maybe it's time to switch IOAPIC default version to 0x20. Signed-off-by: Peter Xu --- V2: - keep compatible for qemu version <= 2.7 [Paolo] hw/intc/ioapic.c | 2 +- include/hw/compat.h | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c index 31791b0..fd9208f 100644 --- a/hw/intc/ioapic.c +++ b/hw/intc/ioapic.c @@ -416,7 +416,7 @@ static void ioapic_realize(DeviceState *dev, Error **errp) } static Property ioapic_properties[] = { - DEFINE_PROP_UINT8("version", IOAPICCommonState, version, 0x11), + DEFINE_PROP_UINT8("version", IOAPICCommonState, version, 0x20), DEFINE_PROP_END_OF_LIST(), }; diff --git a/include/hw/compat.h b/include/hw/compat.h index a1d6694..46412b2 100644 --- a/include/hw/compat.h +++ b/include/hw/compat.h @@ -6,6 +6,10 @@ .driver = "virtio-pci",\ .property = "page-per-vq",\ .value = "on",\ + },{\ + .driver = "ioapic",\ + .property = "version",\ + .value = "0x11",\ }, #define HW_COMPAT_2_6 \ -- 2.7.4