* [Qemu-devel] [PATCH v2] x86: ioapic: boost default version to 0x20
@ 2016-09-23 5:33 Peter Xu
2016-09-23 9:29 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Peter Xu @ 2016-09-23 5:33 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, imammedo, peterx
It's 2.8 now, and maybe it's time to switch IOAPIC default version to
0x20.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
V2:
- keep compatible for qemu version <= 2.7 [Paolo]
hw/intc/ioapic.c | 2 +-
include/hw/compat.h | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
index 31791b0..fd9208f 100644
--- a/hw/intc/ioapic.c
+++ b/hw/intc/ioapic.c
@@ -416,7 +416,7 @@ static void ioapic_realize(DeviceState *dev, Error **errp)
}
static Property ioapic_properties[] = {
- DEFINE_PROP_UINT8("version", IOAPICCommonState, version, 0x11),
+ DEFINE_PROP_UINT8("version", IOAPICCommonState, version, 0x20),
DEFINE_PROP_END_OF_LIST(),
};
diff --git a/include/hw/compat.h b/include/hw/compat.h
index a1d6694..46412b2 100644
--- a/include/hw/compat.h
+++ b/include/hw/compat.h
@@ -6,6 +6,10 @@
.driver = "virtio-pci",\
.property = "page-per-vq",\
.value = "on",\
+ },{\
+ .driver = "ioapic",\
+ .property = "version",\
+ .value = "0x11",\
},
#define HW_COMPAT_2_6 \
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH v2] x86: ioapic: boost default version to 0x20
2016-09-23 5:33 [Qemu-devel] [PATCH v2] x86: ioapic: boost default version to 0x20 Peter Xu
@ 2016-09-23 9:29 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2016-09-23 9:29 UTC (permalink / raw)
To: Peter Xu, qemu-devel; +Cc: imammedo
On 23/09/2016 07:33, Peter Xu wrote:
> It's 2.8 now, and maybe it's time to switch IOAPIC default version to
> 0x20.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>
> V2:
> - keep compatible for qemu version <= 2.7 [Paolo]
>
> hw/intc/ioapic.c | 2 +-
> include/hw/compat.h | 4 ++++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
> index 31791b0..fd9208f 100644
> --- a/hw/intc/ioapic.c
> +++ b/hw/intc/ioapic.c
> @@ -416,7 +416,7 @@ static void ioapic_realize(DeviceState *dev, Error **errp)
> }
>
> static Property ioapic_properties[] = {
> - DEFINE_PROP_UINT8("version", IOAPICCommonState, version, 0x11),
> + DEFINE_PROP_UINT8("version", IOAPICCommonState, version, 0x20),
> DEFINE_PROP_END_OF_LIST(),
> };
>
> diff --git a/include/hw/compat.h b/include/hw/compat.h
> index a1d6694..46412b2 100644
> --- a/include/hw/compat.h
> +++ b/include/hw/compat.h
> @@ -6,6 +6,10 @@
> .driver = "virtio-pci",\
> .property = "page-per-vq",\
> .value = "on",\
> + },{\
> + .driver = "ioapic",\
> + .property = "version",\
> + .value = "0x11",\
> },
>
> #define HW_COMPAT_2_6 \
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-23 9:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-23 5:33 [Qemu-devel] [PATCH v2] x86: ioapic: boost default version to 0x20 Peter Xu
2016-09-23 9:29 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).