qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: "Edgar E . Iglesias" <edgar.iglesias@gmail.com>
Subject: [Qemu-devel] [PATCH 2/4] target-microblaze: Do not dump cpu state with -d in_asm
Date: Fri, 23 Sep 2016 08:29:09 -0700	[thread overview]
Message-ID: <1474644551-5819-2-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1474644551-5819-1-git-send-email-rth@twiddle.net>

Dumping cpu state is what -d cpu is for.

Cc: Edgar E. Iglesias <edgar.iglesias@gmail.com>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 target-microblaze/translate.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/target-microblaze/translate.c b/target-microblaze/translate.c
index 80098ec..5a4a8b9 100644
--- a/target-microblaze/translate.c
+++ b/target-microblaze/translate.c
@@ -1670,13 +1670,6 @@ void gen_intermediate_code(CPUMBState *env, struct TranslationBlock *tb)
         cpu_abort(cs, "Microblaze: unaligned PC=%x\n", pc_start);
     }
 
-    if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM)) {
-#if !SIM_COMPAT
-        qemu_log("--------------\n");
-        log_cpu_state(CPU(cpu), 0);
-#endif
-    }
-
     next_page_start = (pc_start & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE;
     num_insns = 0;
     max_insns = tb->cflags & CF_COUNT_MASK;
@@ -1820,7 +1813,7 @@ void gen_intermediate_code(CPUMBState *env, struct TranslationBlock *tb)
 #if !SIM_COMPAT
     if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM)
         && qemu_log_in_addr_range(pc_start)) {
-        qemu_log("\n");
+        qemu_log("--------------\n");
 #if DISAS_GNU
         log_target_disas(cs, pc_start, dc->pc - pc_start, 0);
 #endif
-- 
2.7.4

  reply	other threads:[~2016-09-23 15:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-23 15:29 [Qemu-devel] [PATCH 1/4] target-cris: Do not dump cpu state with -d in_asm Richard Henderson
2016-09-23 15:29 ` Richard Henderson [this message]
2016-09-23 16:45   ` [Qemu-devel] [PATCH 2/4] target-microblaze: " Edgar E. Iglesias
2016-09-23 15:29 ` [Qemu-devel] [PATCH 3/4] target-openrisc: " Richard Henderson
2016-09-23 15:29 ` [Qemu-devel] [PATCH 4/4] log: Add locking to large logging blocks Richard Henderson
2016-09-24 13:12   ` Paolo Bonzini
2016-09-23 16:45 ` [Qemu-devel] [PATCH 1/4] target-cris: Do not dump cpu state with -d in_asm Edgar E. Iglesias
2016-09-26  8:32 ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474644551-5819-2-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=edgar.iglesias@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).