From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUd9j-0000Vr-O7 for qemu-devel@nongnu.org; Tue, 02 Aug 2016 13:07:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUd9d-0004FS-OH for qemu-devel@nongnu.org; Tue, 02 Aug 2016 13:07:02 -0400 Date: Tue, 2 Aug 2016 13:06:55 -0400 (EDT) From: Paolo Bonzini Message-ID: <147485044.13103634.1470157615989.JavaMail.zimbra@redhat.com> In-Reply-To: <252f57a7-52ac-cb52-e8fc-df998bba0cdb@redhat.com> References: <1469570853-19770-1-git-send-email-jsnow@redhat.com> <1469570853-19770-2-git-send-email-jsnow@redhat.com> <7d6771b0-189f-dab9-d5a8-e336a46a4ea5@redhat.com> <252f57a7-52ac-cb52-e8fc-df998bba0cdb@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.7 1/1] ide: fix halted IO segfault at reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, lersek@redhat.com, armbru@redhat.com, mreitz@redhat.com > > The patch is (was, since it's committed :)) okay, but I think there is > > another bug in the REPORT case, where ide_rw_error and > > ide_atapi_io_error are not calling ide_set_inactive and thus are leaving > > s->bus->dma->aiocb non-NULL. > > > > Paolo > > > > Actually, won't we hit ide_dma_error on REPORT which calls > ide_set_inactive? I think this might be OK, but I have to audit a little > more carefully -- I will do so tomorrow. > > I think the ide_rw_error case is likely OK, but I always manage to > forget exactly how the ATAPI DMA looks. Indeed ide_rw_error is okay because ide_sector_read and ide_sector_write do reset pio_aiocb early enough; ATAPI is wrong because IDE_RETRY_ATAPI does not pass IS_IDE_RETRY_DMA. Paolo