From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38278)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1booNS-0001HX-Fu
	for qemu-devel@nongnu.org; Tue, 27 Sep 2016 05:08:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1booNM-0004qi-Bd
	for qemu-devel@nongnu.org; Tue, 27 Sep 2016 05:08:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45334)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1booNM-0004qb-5B
	for qemu-devel@nongnu.org; Tue, 27 Sep 2016 05:08:32 -0400
Message-ID: <1474967309.26376.12.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 27 Sep 2016 11:08:29 +0200
In-Reply-To: <1474893837-13010-3-git-send-email-jgross@suse.com>
References: <1474893837-13010-1-git-send-email-jgross@suse.com>
	<1474893837-13010-3-git-send-email-jgross@suse.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2] xen: add qemu device for each pvusb
 backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juergen Gross <jgross@suse.com>
Cc: qemu-devel@nongnu.org, xen-devel@lists.xensource.com, anthony.perard@citrix.com, sstabellini@kernel.org

  Hi,

>  struct usbback_info {
>      struct XenDevice         xendev;  /* must be first */
> +    char                     id[24];
> +    struct USBBACKDevice     *dev;
>      USBBus                   bus;
>      void                     *urb_sring;
>      void                     *conn_sring;
> @@ -116,6 +124,10 @@ struct usbback_info {
>      QEMUBH                   *bh;
>  };
> =20
> +typedef struct USBBACKDevice {
> +    DeviceState qdev;
> +} USBBACKDevice;

Hmm, I think the xen core needs better QOM support ...

struct XenDevice should have a DeviceState element, so it can be used as
device object directly instead of attaching a device object like
this ...

cheers,
  Gerd