From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com, pbonzini@redhat.com,
mst@redhat.com, dgilbert@redhat.com, peter.maydell@linaro.org,
eblake@redhat.com, rth@twiddle.net, armbru@redhat.com,
Peter Lieven <pl@kamp.de>
Subject: [Qemu-devel] [PATCH V9 5/7] coroutine-sigaltstack: use helper for allocating stack memory
Date: Tue, 27 Sep 2016 11:58:44 +0200 [thread overview]
Message-ID: <1474970326-10271-6-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1474970326-10271-1-git-send-email-pl@kamp.de>
Signed-off-by: Peter Lieven <pl@kamp.de>
---
util/coroutine-sigaltstack.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/util/coroutine-sigaltstack.c b/util/coroutine-sigaltstack.c
index a5bcb7e..f6fc49a 100644
--- a/util/coroutine-sigaltstack.c
+++ b/util/coroutine-sigaltstack.c
@@ -33,6 +33,7 @@
typedef struct {
Coroutine base;
void *stack;
+ size_t stack_size;
sigjmp_buf env;
} CoroutineSigAltStack;
@@ -143,7 +144,6 @@ static void coroutine_trampoline(int signal)
Coroutine *qemu_coroutine_new(void)
{
- const size_t stack_size = COROUTINE_STACK_SIZE;
CoroutineSigAltStack *co;
CoroutineThreadState *coTS;
struct sigaction sa;
@@ -164,7 +164,8 @@ Coroutine *qemu_coroutine_new(void)
*/
co = g_malloc0(sizeof(*co));
- co->stack = g_malloc(stack_size);
+ co->stack_size = COROUTINE_STACK_SIZE;
+ co->stack = qemu_alloc_stack(&co->stack_size);
co->base.entry_arg = &old_env; /* stash away our jmp_buf */
coTS = coroutine_get_thread_state();
@@ -189,7 +190,7 @@ Coroutine *qemu_coroutine_new(void)
* Set the new stack.
*/
ss.ss_sp = co->stack;
- ss.ss_size = stack_size;
+ ss.ss_size = co->stack_size;
ss.ss_flags = 0;
if (sigaltstack(&ss, &oss) < 0) {
abort();
@@ -253,7 +254,7 @@ void qemu_coroutine_delete(Coroutine *co_)
{
CoroutineSigAltStack *co = DO_UPCAST(CoroutineSigAltStack, base, co_);
- g_free(co->stack);
+ qemu_free_stack(co->stack, co->stack_size);
g_free(co);
}
--
1.9.1
next prev parent reply other threads:[~2016-09-27 9:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 9:58 [Qemu-devel] [PATCH V9 0/7] coroutine: mmap stack memory and stack size Peter Lieven
2016-09-27 9:58 ` [Qemu-devel] [PATCH V9 1/7] oslib-posix: add helpers for stack alloc and free Peter Lieven
2016-09-27 11:59 ` Kevin Wolf
2016-09-27 12:02 ` Peter Lieven
2016-09-27 9:58 ` [Qemu-devel] [PATCH V9 2/7] coroutine-sigaltstack: rename coroutine struct appropriately Peter Lieven
2016-09-27 15:36 ` Eric Blake
2016-09-27 9:58 ` [Qemu-devel] [PATCH V9 3/7] coroutine: add a macro for the coroutine stack size Peter Lieven
2016-09-27 9:58 ` [Qemu-devel] [PATCH V9 4/7] coroutine-ucontext: use helper for allocating stack memory Peter Lieven
2016-09-27 15:37 ` Eric Blake
2016-09-27 9:58 ` Peter Lieven [this message]
2016-09-27 15:37 ` [Qemu-devel] [PATCH V9 5/7] coroutine-sigaltstack: " Eric Blake
2016-09-27 9:58 ` [Qemu-devel] [PATCH V9 6/7] oslib-posix: add a configure switch to debug stack usage Peter Lieven
2016-09-27 15:48 ` Eric Blake
2016-09-27 9:58 ` [Qemu-devel] [PATCH V9 7/7] coroutine: reduce stack size to 60kB Peter Lieven
2016-09-27 15:50 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474970326-10271-6-git-send-email-pl@kamp.de \
--to=pl@kamp.de \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).