qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 01/20] target-i386: Remove unused X86CPUDefinition::xlevel2 field
Date: Tue, 27 Sep 2016 17:12:11 -0300	[thread overview]
Message-ID: <1475007150-14665-2-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1475007150-14665-1-git-send-email-ehabkost@redhat.com>

No CPU model in builtin_x86_defs has xlevel2 set, so it is always
zero. Delete the field.

Note that this is not an user-visible change. It doesn't remove
the ability to set xlevel2 on the command-line, it just removes
an unused field in builtin_x86_defs.

Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target-i386/cpu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index db12728..920b78f 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -761,7 +761,6 @@ struct X86CPUDefinition {
     const char *name;
     uint32_t level;
     uint32_t xlevel;
-    uint32_t xlevel2;
     /* vendor is zero-terminated, 12 character ASCII string */
     char vendor[CPUID_VENDOR_SZ + 1];
     int family;
@@ -2214,7 +2213,6 @@ static void x86_cpu_load_def(X86CPU *cpu, X86CPUDefinition *def, Error **errp)
     object_property_set_int(OBJECT(cpu), def->model, "model", errp);
     object_property_set_int(OBJECT(cpu), def->stepping, "stepping", errp);
     object_property_set_int(OBJECT(cpu), def->xlevel, "xlevel", errp);
-    object_property_set_int(OBJECT(cpu), def->xlevel2, "xlevel2", errp);
     object_property_set_str(OBJECT(cpu), def->model_id, "model-id", errp);
     for (w = 0; w < FEATURE_WORDS; w++) {
         env->features[w] = def->features[w];
-- 
2.7.4

  reply	other threads:[~2016-09-27 20:12 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-27 20:12 [Qemu-devel] [PULL 00/20] x86 and machine queue, 2016-09-27 Eduardo Habkost
2016-09-27 20:12 ` Eduardo Habkost [this message]
2016-09-27 20:12 ` [Qemu-devel] [PULL 02/20] target-i386: Add a marker to end of the region zeroed on reset Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 03/20] tests: Add test code for CPUID level/xlevel handling Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 04/20] tests: Test CPUID level handling for old machines Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 05/20] target-i386: Automatically set level/xlevel/xlevel2 when needed Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 06/20] target-i386: Enable CPUID[0x8000000A] if SVM is enabled Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 07/20] linux-user: remove #define smp_{cores, threads} Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 08/20] target-i386: Move feature name arrays inside FeatureWordInfo Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 09/20] target-i386: Don't try to enable PT State xsave component Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 10/20] target-i386: xsave: Calculate enabled components only once Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 11/20] target-i386: xsave: Simplify CPUID[0xD, 0].{EAX, EDX} calculation Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 12/20] target-i386: xsave: Helper function to calculate xsave area size Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 13/20] target-i386: xsave: Calculate set of xsave components on realize Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 14/20] target-i386: Move xsave component mask to features array Eduardo Habkost
2016-10-03 16:42   ` Daniel P. Berrange
2016-10-03 19:10     ` Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 15/20] target-i386: Remove has_msr_mtrr global variable Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 16/20] target-i386: Remove has_msr_hv_apic " Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 17/20] target-i386: Remove has_msr_hv_tsc " Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 18/20] target-i386: Clear KVM CPUID features if KVM is disabled Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 19/20] target-i386: Remove has_msr_* global vars for KVM features Eduardo Habkost
2016-09-27 20:12 ` [Qemu-devel] [PULL 20/20] sysbus: Remove ignored return value of FindSysbusDeviceFunc Eduardo Habkost
2016-09-27 23:31 ` [Qemu-devel] [PULL 00/20] x86 and machine queue, 2016-09-27 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475007150-14665-2-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).