From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bp7Sn-00007y-FC for qemu-devel@nongnu.org; Wed, 28 Sep 2016 01:31:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bp7Si-00021o-Fk for qemu-devel@nongnu.org; Wed, 28 Sep 2016 01:31:25 -0400 Received: from mail-pa0-x242.google.com ([2607:f8b0:400e:c03::242]:34338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bp7Si-00021N-9L for qemu-devel@nongnu.org; Wed, 28 Sep 2016 01:31:20 -0400 Received: by mail-pa0-x242.google.com with SMTP id r9so925577paz.1 for ; Tue, 27 Sep 2016 22:31:19 -0700 (PDT) From: Wanpeng Li Date: Wed, 28 Sep 2016 13:31:09 +0800 Message-Id: <1475040669-29085-1-git-send-email-wanpeng.li@hotmail.com> Subject: [Qemu-devel] [PATCH] target-i386: fix losing XCR0 processor state component bits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kvm@vger.kernel.org, qemu-devel@nongnu.org Cc: Wanpeng Li , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" From: Wanpeng Li Commit 96193c22a "target-i386: Move xsave component mask to features array" leverages features array to handle XCR0 processor state component bits, however, it introduces a regression: warning: host doesn't support requested feature: CPUID.0DH:EAX [bit 0] warning: host doesn't support requested feature: CPUID.0DH:EAX [bit 1] warning: host doesn't support requested feature: CPUID.0DH:EAX [bit 2] My desktop doesn't have enough advance features, so just X87,SSE,AVX warnings are splat when I boot a guest. The get migratable flags logic in x86_cpu_filter_features() path will filter out the feature flags which are unsupported and unmigratable. However, the bits of XCR0 processor state component featureword don't have feat_names, and some features like SSE/AVX etc have feat_names in CPUID.01H:EDX, CPUID.01H:ECX, so they are treated as unsupported. This patch fix it by don't filter out XCR0 processor state components bits though they don't have feat_names just as before commit 96193c22ab3. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Michael S. Tsirkin Signed-off-by: Wanpeng Li --- target-i386/cpu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index ad09246..9d24eff 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -2156,6 +2156,10 @@ static uint32_t x86_cpu_get_supported_feature_word(FeatureWord w, r = kvm_arch_get_supported_cpuid(kvm_state, wi->cpuid_eax, wi->cpuid_ecx, wi->cpuid_reg); + if ((w == FEAT_XSAVE_COMP_LO) || + (w == FEAT_XSAVE_COMP_HI)) { + return r; + } } else if (tcg_enabled()) { r = wi->tcg_features; } else { -- 1.9.1