From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpCkS-0003Wj-Of for qemu-devel@nongnu.org; Wed, 28 Sep 2016 07:10:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpCkO-0007Ws-HH for qemu-devel@nongnu.org; Wed, 28 Sep 2016 07:09:59 -0400 Received: from li2-213.members.linode.com ([69.56.173.213]:37336 helo=mail.zilogic.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpCkO-0007TE-BP for qemu-devel@nongnu.org; Wed, 28 Sep 2016 07:09:56 -0400 From: Vijay Kumar B Date: Wed, 28 Sep 2016 16:39:18 +0530 Message-Id: <1475060958-7760-1-git-send-email-vijaykumar@zilogic.com> Subject: [Qemu-devel] [PATCH] usb: Fix incorrect default DMA offset. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Vijay Kumar B , kraxel@redhat.com The default DMA offset is set to 3. When the property is not set by the consumer, the default causes DMA access to be shifted by 3 bytes. In PXA, this results in incorrect DMA access, leading to error notification in the USB controller driver. A better default would be 0, so that there is no offset, when the consumer does not specify one. Signed-off-by: Vijay Kumar B. Reviewed-by: Deepak S. --- hw/usb/hcd-ohci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index fa57038..c82a92f 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -2139,7 +2139,7 @@ static const TypeInfo ohci_pci_info = { static Property ohci_sysbus_properties[] = { DEFINE_PROP_UINT32("num-ports", OHCISysBusState, num_ports, 3), - DEFINE_PROP_DMAADDR("dma-offset", OHCISysBusState, dma_offset, 3), + DEFINE_PROP_DMAADDR("dma-offset", OHCISysBusState, dma_offset, 0), DEFINE_PROP_END_OF_LIST(), }; -- 2.1.4