qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Laurent Vivier <lvivier@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL 4/7] libqos: fix qvring_init()
Date: Wed, 28 Sep 2016 19:15:34 +0100	[thread overview]
Message-ID: <1475086537-31704-5-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1475086537-31704-1-git-send-email-stefanha@redhat.com>

From: Laurent Vivier <lvivier@redhat.com>

"vq->desc[i].addr" is a 64bit value,
so write it with writeq(), not writew().

struct vring_desc {
    __virtio64 addr;
    __virtio32 len;
    __virtio16 flags;
    __virtio16 next;
};

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Message-id: 1474903450-9605-1-git-send-email-lvivier@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 tests/libqos/virtio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/libqos/virtio.c b/tests/libqos/virtio.c
index 37ff860..105bcce 100644
--- a/tests/libqos/virtio.c
+++ b/tests/libqos/virtio.c
@@ -147,7 +147,7 @@ void qvring_init(const QGuestAllocator *alloc, QVirtQueue *vq, uint64_t addr)
 
     for (i = 0; i < vq->size - 1; i++) {
         /* vq->desc[i].addr */
-        writew(vq->desc + (16 * i), 0);
+        writeq(vq->desc + (16 * i), 0);
         /* vq->desc[i].next */
         writew(vq->desc + (16 * i) + 14, i + 1);
     }
-- 
2.7.4

  parent reply	other threads:[~2016-09-28 18:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 18:15 [Qemu-devel] [PULL 0/7] Block patches Stefan Hajnoczi
2016-09-28 18:15 ` [Qemu-devel] [PULL 1/7] block: mirror: fix wrong comment of mirror_start Stefan Hajnoczi
2016-09-28 18:15 ` [Qemu-devel] [PULL 2/7] aio-posix: avoid unnecessary aio_epoll_enabled() calls Stefan Hajnoczi
2016-09-28 18:15 ` [Qemu-devel] [PULL 3/7] iothread: check iothread->ctx before aio_context_unref to avoid assertion Stefan Hajnoczi
2016-09-28 18:15 ` Stefan Hajnoczi [this message]
2016-09-28 18:15 ` [Qemu-devel] [PULL 5/7] coroutine: add qemu_coroutine_entered() function Stefan Hajnoczi
2016-09-28 18:15 ` [Qemu-devel] [PULL 6/7] test-coroutine: test qemu_coroutine_entered() Stefan Hajnoczi
2016-09-28 18:15 ` [Qemu-devel] [PULL 7/7] linux-aio: fix re-entrant completion processing Stefan Hajnoczi
2016-09-28 22:02 ` [Qemu-devel] [PULL 0/7] Block patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475086537-31704-5-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).