Re: [Qemu-devel] [PATCH v9 2/4] qemu: URI parsing library

[Paolo Bonzini <pbonzini@redhat.com>]

----- Messaggio originale -----
> Da: "Richard W.M. Jones" <rjones@redhat.com>
> A: "Bharata B Rao" <bharata@linux.vnet.ibm.com>
> Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>, "Kevin Wolf" <kwolf@redhat.com>, "Avi Kivity"
> <avi@redhat.com>, "Anthony Liguori" <aliguori@us.ibm.com>, "Stefan Hajnoczi" <stefanha@gmail.com>, "Blue Swirl"
> <blauwirbel@gmail.com>, "Anand Avati" <aavati@redhat.com>, "Vijay Bellur" <vbellur@redhat.com>, "Amar Tumballi"
> <amarts@redhat.com>, "Harsh Bora" <harsh@linux.vnet.ibm.com>, "Daniel Veillard" <veillard@redhat.com>
> Inviato: Lunedì, 24 settembre 2012 12:27:38
> Oggetto: Re: [PATCH v9 2/4] qemu: URI parsing library
> 
> 
> On Mon, Sep 24, 2012 at 02:42:02PM +0530, Bharata B Rao wrote:
> > qemu: URI parsing library
> > 
> > From: Paolo Bonzini <pbonzini@redhat.com>
> > 
> > Add a new URI parsing library to QEMU. The code has been borrowed
> > from libxml2 and libvirt.
> 
> Rather than duplicating the libxml2 code, I think it would be better
> to depend on libxml2.  While it's not ideal to add more external
> dependencies, libxml2 is very commonly available.  Also libxml2 gets
> frequent security updates and you never know when the URI code here
> might be found to contain some sort of bug / security issue.

You're preaching to the choir here, but I think there are limited
advantages in this case.  The URI parsing has seen hardly any change
in the last 2 years and is surprisingly self-contained even in libxml2:
the dependencies were limited to memory allocation hooks basically.

A better plan would be to incorporate this code into glib, completing
the extremely sparse URI support that is already there.  However, we
would not be able to use it anyway, because we support compiling on old
glib versions.

Paolo

> This will need a change to the qemu configure script of course.
> 
> Rich.
> 
> --
> Richard Jones, Virtualization Group, Red Hat
> http://people.redhat.com/~rjones
> virt-df lists disk usage of guests without needing to install any
> software inside the virtual machine.  Supports Linux and Windows.
> http://et.redhat.com/~rjones/virt-df/
>