qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@redhat.com>
To: eric.auger@redhat.com, eric.auger.pro@gmail.com,
	qemu-devel@nongnu.org, alex.williamson@redhat.com,
	armbru@redhat.com
Subject: [Qemu-devel] [PATCH v3 00/16] Convert VFIO-PCI to realize
Date: Sun,  2 Oct 2016 20:49:58 +0000	[thread overview]
Message-ID: <1475441414-3118-1-git-send-email-eric.auger@redhat.com> (raw)

This series converts VFIO-PCI to realize. It also aims at improving
the error reporting in case of QMP hot-plug.

Before the series, a device_add failure would have reported:
{"error": {"class": "GenericError", "desc": "Device initialization
failed"}}.

Now the actual error cause is reported.

A side effect of this series is the cleanup of the error handling
in vfio-platform.

Git Information:
https://github.com/eauger/qemu/tree/v2.7.0_vfio_realize_v3

History:

v2 -> v3:
- Addressed Markus' comments :
  - don't use local error object if not necessary
  - fix some error handling: see individual patches
  - use error objects also on vfio platform realize path although
    hot-plug is not allowed, but that's cleaner I think.
  - bug fix in vfio platform

v1 -> v2:
- Error object is cascaded downto vfio_intx_enable, vfio_add_capabilities
  vfio_pci_igd_opregion_init, vfio_get_group, vfio_get_device
- Actual migration to realize happens at a later stage following Markus'
  guidance
- special handling of the case where the end-user omits the host property
- error_setg_errno now uses positive errno
- more detailed commit message
- fix "cannot enable AER cannot" functional change

Eric Auger (16):
  vfio/pci: Use local error object in vfio_initfn
  vfio/pci: Pass an error object to vfio_populate_vga
  vfio/pci: Pass an error object to vfio_populate_device
  vfio/pci: Pass an error object to vfio_msix_early_setup
  vfio/pci: Pass an error object to vfio_intx_enable
  vfio/pci: Pass an error object to vfio_add_capabilities
  vfio/pci: Pass an error object to vfio_pci_igd_opregion_init
  vfio: Pass an error object to vfio_get_group
  vfio: Pass an error object to vfio_get_device
  vfio/platform: Pass an error object to vfio_populate_device
  vfio/platform: fix a wrong returned value in vfio_populate_device
  vfio/platform: Pass an error object to vfio_base_device_init
  vfio/pci: Conversion to realize
  vfio/pci: Remove vfio_msix_early_setup returned value
  vfio/pci: Remove vfio_populate_device returned value
  vfio/pci: Handle host oversight

 hw/vfio/common.c              |  33 ++---
 hw/vfio/pci-quirks.c          |  14 ++-
 hw/vfio/pci.c                 | 271 +++++++++++++++++++++++-------------------
 hw/vfio/pci.h                 |   5 +-
 hw/vfio/platform.c            |  65 +++++-----
 hw/vfio/trace-events          |   2 +-
 include/hw/vfio/vfio-common.h |   7 +-
 7 files changed, 223 insertions(+), 174 deletions(-)

-- 
1.9.1

             reply	other threads:[~2016-10-02 20:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-02 20:49 Eric Auger [this message]
2016-10-02 20:49 ` [Qemu-devel] [PATCH v3 01/16] vfio/pci: Use local error object in vfio_initfn Eric Auger
2016-10-02 20:50 ` [Qemu-devel] [PATCH v3 02/16] vfio/pci: Pass an error object to vfio_populate_vga Eric Auger
2016-10-02 20:50 ` [Qemu-devel] [PATCH v3 03/16] vfio/pci: Pass an error object to vfio_populate_device Eric Auger
2016-10-02 20:50 ` [Qemu-devel] [PATCH v3 04/16] vfio/pci: Pass an error object to vfio_msix_early_setup Eric Auger
2016-10-02 20:50 ` [Qemu-devel] [PATCH v3 05/16] vfio/pci: Pass an error object to vfio_intx_enable Eric Auger
2016-10-02 20:50 ` [Qemu-devel] [PATCH v3 06/16] vfio/pci: Pass an error object to vfio_add_capabilities Eric Auger
2016-10-02 20:50 ` [Qemu-devel] [PATCH v3 07/16] vfio/pci: Pass an error object to vfio_pci_igd_opregion_init Eric Auger
2016-10-02 20:50 ` [Qemu-devel] [PATCH v3 08/16] vfio: Pass an error object to vfio_get_group Eric Auger
2016-10-03  7:55   ` Auger Eric
2016-10-02 20:50 ` [Qemu-devel] [PATCH v3 09/16] vfio: Pass an error object to vfio_get_device Eric Auger
2016-10-02 20:50 ` [Qemu-devel] [PATCH v3 10/16] vfio/platform: Pass an error object to vfio_populate_device Eric Auger
2016-10-02 20:50 ` [Qemu-devel] [PATCH v3 11/16] vfio/platform: fix a wrong returned value in vfio_populate_device Eric Auger
2016-10-02 20:50 ` [Qemu-devel] [PATCH v3 12/16] vfio/platform: Pass an error object to vfio_base_device_init Eric Auger
2016-10-02 20:50 ` [Qemu-devel] [PATCH v3 13/16] vfio/pci: Conversion to realize Eric Auger
2016-10-02 20:50 ` [Qemu-devel] [PATCH v3 14/16] vfio/pci: Remove vfio_msix_early_setup returned value Eric Auger
2016-10-02 20:50 ` [Qemu-devel] [PATCH v3 15/16] vfio/pci: Remove vfio_populate_device " Eric Auger
2016-10-02 20:50 ` [Qemu-devel] [PATCH v3 16/16] vfio/pci: Handle host oversight Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475441414-3118-1-git-send-email-eric.auger@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).