From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brun3-0007br-2T for qemu-devel@nongnu.org; Wed, 05 Oct 2016 18:35:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brumy-00068H-4I for qemu-devel@nongnu.org; Wed, 05 Oct 2016 18:35:52 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:45489) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brumv-00062u-QV for qemu-devel@nongnu.org; Wed, 05 Oct 2016 18:35:48 -0400 From: "Emilio G. Cota" Date: Wed, 5 Oct 2016 18:34:37 -0400 Message-Id: <1475706880-10667-1-git-send-email-cota@braap.org> In-Reply-To: References: Subject: [Qemu-devel] [PATCH 0/3] qht fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "Daniel P . Berrange" , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , QEMU Developers Patch 1 fixes a warning that gcc may unnecessarily emit. Patch 2 fixes a real bug that sometimes shows up as a segfault in test-qht. Daniel reported it yesterday on IRC; the trick to easily trigger it is to run on RHEL6 (or CentOS6). It is very likely that this is the test-qht failure that Peter reported here: https://lists.nongnu.org/archive/html/qemu-devel/2016-08/msg03771.html (we cannot be 100% sure due to the lack of output there; however the fact that it's the resize what fails supports the hypothesis that we're indeed hitting the same bug.) I'm therefore adding Peter's reported-by tag to the patch along with Daniel's. Patch 3 is merely good practice, since test-qht is single-threaded. However I like having it, since test-qht serves as a de facto usage example of qht. Given that patch 2 alone would conflict without previously applying patch 1, I propose to merge both patches 1 & 2 to 2.7-stable. I'll send them to qemu-stable once the patchset is picked up to be merged onto master. Thanks, Emilio