From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: agraf@suse.de, qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Avinesh Kumar <avinesku@linux.vnet.ibm.com>,
Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 15/29] target-ppc: fix invalid mask - cmpl, bctar
Date: Thu, 6 Oct 2016 23:03:01 +1100 [thread overview]
Message-ID: <1475755395-27307-16-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1475755395-27307-1-git-send-email-david@gibson.dropbear.id.au>
From: Avinesh Kumar <avinesku@linux.vnet.ibm.com>
cmpl: invalid bit mask should be 0x00400001
bctar: invalid bit mask should be 0x0000E000
Signed-off-by: Avinesh Kumar <avinesku@linux.vnet.ibm.com>
Signed-off-by: Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
target-ppc/translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 8eefd82..dab8f19 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -6203,7 +6203,7 @@ static opcode_t opcodes[] = {
GEN_HANDLER(invalid, 0x00, 0x00, 0x00, 0xFFFFFFFF, PPC_NONE),
GEN_HANDLER(cmp, 0x1F, 0x00, 0x00, 0x00400000, PPC_INTEGER),
GEN_HANDLER(cmpi, 0x0B, 0xFF, 0xFF, 0x00400000, PPC_INTEGER),
-GEN_HANDLER(cmpl, 0x1F, 0x00, 0x01, 0x00400000, PPC_INTEGER),
+GEN_HANDLER(cmpl, 0x1F, 0x00, 0x01, 0x00400001, PPC_INTEGER),
GEN_HANDLER(cmpli, 0x0A, 0xFF, 0xFF, 0x00400000, PPC_INTEGER),
#if defined(TARGET_PPC64)
GEN_HANDLER_E(cmpeqb, 0x1F, 0x00, 0x07, 0x00600000, PPC_NONE, PPC2_ISA300),
@@ -6297,7 +6297,7 @@ GEN_HANDLER(b, 0x12, 0xFF, 0xFF, 0x00000000, PPC_FLOW),
GEN_HANDLER(bc, 0x10, 0xFF, 0xFF, 0x00000000, PPC_FLOW),
GEN_HANDLER(bcctr, 0x13, 0x10, 0x10, 0x00000000, PPC_FLOW),
GEN_HANDLER(bclr, 0x13, 0x10, 0x00, 0x00000000, PPC_FLOW),
-GEN_HANDLER_E(bctar, 0x13, 0x10, 0x11, 0, PPC_NONE, PPC2_BCTAR_ISA207),
+GEN_HANDLER_E(bctar, 0x13, 0x10, 0x11, 0x0000E000, PPC_NONE, PPC2_BCTAR_ISA207),
GEN_HANDLER(mcrf, 0x13, 0x00, 0xFF, 0x00000001, PPC_INTEGER),
GEN_HANDLER(rfi, 0x13, 0x12, 0x01, 0x03FF8001, PPC_FLOW),
#if defined(TARGET_PPC64)
--
2.7.4
next prev parent reply other threads:[~2016-10-06 12:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 12:02 [Qemu-devel] [PULL 00/29] ppc-for-2.8 queue 20161006 David Gibson
2016-10-06 12:02 ` [Qemu-devel] [PULL 01/29] spapr_vscsi: fix build error introduced by f19661c8 David Gibson
2016-10-06 12:02 ` [Qemu-devel] [PULL 02/29] tests: Test IPv6 and ppc64 in the PXE tester David Gibson
2016-10-06 12:02 ` [Qemu-devel] [PULL 03/29] pseries: Add 2.8 machine type, set up compatibility macros David Gibson
2016-10-06 12:02 ` [Qemu-devel] [PULL 04/29] hw/ppc/spapr: Move code related to "ibm, pa-features" to a separate function David Gibson
2016-10-06 12:02 ` [Qemu-devel] [PULL 05/29] hw/ppc/spapr: Fix the selection of the processor features David Gibson
2016-10-06 12:02 ` [Qemu-devel] [PULL 06/29] ppc: Check the availability of transactional memory David Gibson
2016-10-06 12:02 ` [Qemu-devel] [PULL 07/29] target-ppc: Implement mfvsrld instruction David Gibson
2016-10-06 12:02 ` [Qemu-devel] [PULL 08/29] target-ppc: Implement mtvsrdd instruction David Gibson
2016-10-06 12:02 ` [Qemu-devel] [PULL 09/29] target-ppc: improve lxvw4x implementation David Gibson
2016-10-06 12:02 ` [Qemu-devel] [PULL 10/29] target-ppc: improve stxvw4x implementation David Gibson
2016-10-06 12:02 ` [Qemu-devel] [PULL 11/29] target-ppc: add lxvh8x instruction David Gibson
2016-10-06 12:02 ` [Qemu-devel] [PULL 12/29] target-ppc: add stxvh8x instruction David Gibson
2016-10-06 12:02 ` [Qemu-devel] [PULL 13/29] target-ppc: add lxvb16x instruction David Gibson
2016-10-06 12:03 ` [Qemu-devel] [PULL 14/29] target-ppc: add stxvb16x instruction David Gibson
2016-10-06 12:03 ` David Gibson [this message]
2016-10-06 12:03 ` [Qemu-devel] [PULL 16/29] target-ppc: add vector compare not equal instructions David Gibson
2016-10-06 12:03 ` [Qemu-devel] [PULL 17/29] target-ppc: add vclzlsbb/vctzlsbb instructions David Gibson
2016-10-06 12:03 ` [Qemu-devel] [PULL 18/29] target-ppc: Implement mtvsrws instruction David Gibson
2016-10-06 12:03 ` [Qemu-devel] [PULL 19/29] MAINTAINERS: Add two more ppc related files David Gibson
2016-10-06 12:03 ` [Qemu-devel] [PULL 20/29] target-ppc/kvm: Add a wrapper function to check for KVM-PR David Gibson
2016-10-06 12:03 ` [Qemu-devel] [PULL 21/29] target-ppc/kvm: Enable transactional memory on POWER8 with KVM-HV, too David Gibson
2016-10-06 12:03 ` [Qemu-devel] [PULL 22/29] target-ppc: fix vmx instruction type/type2 David Gibson
2016-10-06 12:03 ` [Qemu-devel] [PULL 23/29] libqos: add PPC64 PCI support David Gibson
2016-10-06 12:03 ` [Qemu-devel] [PULL 24/29] libqos: add PCI management in qtest_vboot()/qtest_shutdown() David Gibson
2016-10-06 12:03 ` [Qemu-devel] [PULL 25/29] libqos: use generic qtest_shutdown() David Gibson
2016-10-06 12:03 ` [Qemu-devel] [PULL 26/29] tests: enable ohci/uhci/xhci tests on PPC64 David Gibson
2016-10-06 12:03 ` [Qemu-devel] [PULL 27/29] spapr: fix check of cpu alias name in spapr_get_cpu_core_type() David Gibson
2016-10-06 12:03 ` [Qemu-devel] [PULL 28/29] tests/pxe: Use -nodefaults to speed up ppc64/ipv6 pxe test David Gibson
2016-10-06 12:03 ` [Qemu-devel] [PULL 29/29] hw/ppc/spapr: Use POWER8 by default for the pseries-2.8 machine David Gibson
2016-10-06 13:35 ` [Qemu-devel] [PULL 00/29] ppc-for-2.8 queue 20161006 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475755395-27307-16-git-send-email-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=avinesku@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=raji@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).