qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 08/10] scripts: Allow block module to not define BlockDriver
Date: Fri,  7 Oct 2016 15:42:57 +0200	[thread overview]
Message-ID: <1475847779-7336-9-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1475847779-7336-1-git-send-email-kwolf@redhat.com>

From: Fam Zheng <famz@redhat.com>

Signed-off-by: Fam Zheng <famz@redhat.com>
Message-id: 1473043845-13197-2-git-send-email-famz@redhat.com
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 scripts/modules/module_block.py | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/scripts/modules/module_block.py b/scripts/modules/module_block.py
index db4fb54..3f73007 100644
--- a/scripts/modules/module_block.py
+++ b/scripts/modules/module_block.py
@@ -37,7 +37,6 @@ def add_module(fheader, library, format_name, protocol_name):
 def process_file(fheader, filename):
     # This parser assumes the coding style rules are being followed
     with open(filename, "r") as cfile:
-        found_something = False
         found_start = False
         library, _ = os.path.splitext(os.path.basename(filename))
         for line in cfile:
@@ -51,16 +50,10 @@ def process_file(fheader, filename):
                     add_module(fheader, library, format_name, protocol_name)
                     found_start = False
             elif line.find("static BlockDriver") != -1:
-                found_something = True
                 found_start = True
                 format_name = ""
                 protocol_name = ""
 
-        if not found_something:
-            print("No BlockDriver struct found in " + filename + ". \
-                    Is this really a module?", file=sys.stderr)
-            sys.exit(1)
-
 def print_top(fheader):
     fheader.write('''/* AUTOMATICALLY GENERATED, DO NOT MODIFY */
 /*
-- 
1.8.3.1

  parent reply	other threads:[~2016-10-07 13:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07 13:42 [Qemu-devel] [PULL 00/10] Block layer patches Kevin Wolf
2016-10-07 13:42 ` [Qemu-devel] [PULL 01/10] block: use bdrv_add_before_write_notifier Kevin Wolf
2016-10-07 13:42 ` [Qemu-devel] [PULL 02/10] async: add aio_bh_schedule_oneshot Kevin Wolf
2016-10-07 13:42 ` [Qemu-devel] [PULL 03/10] block: use aio_bh_schedule_oneshot Kevin Wolf
2016-10-07 13:42 ` [Qemu-devel] [PULL 04/10] block: Add bdrv_runtime_opts to query-command-line-options Kevin Wolf
2016-10-07 13:42 ` [Qemu-devel] [PULL 05/10] block: Add node name to BLOCK_IO_ERROR event Kevin Wolf
2016-10-07 13:42 ` [Qemu-devel] [PULL 06/10] block-backend: Remember if attached device is non-qdev Kevin Wolf
2016-10-07 13:42 ` [Qemu-devel] [PULL 07/10] block: Add qdev ID to DEVICE_TRAY_MOVED Kevin Wolf
2016-10-07 13:42 ` Kevin Wolf [this message]
2016-10-07 13:42 ` [Qemu-devel] [PULL 09/10] module: Don't load the same module if requested multiple times Kevin Wolf
2016-10-07 13:42 ` [Qemu-devel] [PULL 10/10] dmg: Move libbz2 code to dmg-bz2.so Kevin Wolf
2016-10-10  9:39 ` [Qemu-devel] [PULL 00/10] Block layer patches Peter Maydell
2016-10-10 11:37   ` Kevin Wolf
2016-10-10 15:23     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475847779-7336-9-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).