From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Michal Privoznik <mprivozn@redhat.com>
Subject: [Qemu-devel] [PULL 25/39] qemu_kill_report: Report PID name too
Date: Fri, 7 Oct 2016 18:57:49 +0200 [thread overview]
Message-ID: <1475859483-32234-26-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1475859483-32234-1-git-send-email-pbonzini@redhat.com>
From: Michal Privoznik <mprivozn@redhat.com>
When qemu is being killed, its last words are:
2016-08-31T11:48:15.293587Z qemu-system-x86_64: terminating on signal 15 from pid 11180
That's nice, but what process is 11180? What if I told you we can
do better:
2016-08-31T11:48:15.293587Z qemu-system-x86_64: terminating on signal 15 from pid 11180 (/usr/sbin/libvirtd)
And that's exactly what this patch does.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Message-Id: <a2ba85a8e349a0ea9ee06424226197a03cd04bd3.1474987617.git.mprivozn@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
vl.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index f3abd99..6c5a51c 100644
--- a/vl.c
+++ b/vl.c
@@ -1675,8 +1675,12 @@ static void qemu_kill_report(void)
*/
error_report("terminating on signal %d", shutdown_signal);
} else {
- error_report("terminating on signal %d from pid " FMT_pid,
- shutdown_signal, shutdown_pid);
+ char *shutdown_cmd = qemu_get_pid_name(shutdown_pid);
+
+ error_report("terminating on signal %d from pid " FMT_pid " (%s)",
+ shutdown_signal, shutdown_pid,
+ shutdown_cmd ? shutdown_cmd : "<unknown process>");
+ g_free(shutdown_cmd);
}
shutdown_signal = -1;
}
--
2.7.4
next prev parent reply other threads:[~2016-10-07 16:58 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 16:57 [Qemu-devel] [PULL 00/39] Misc patches for 2016-10-07 Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 01/39] hw/iommu: Fix problems reported by Coverity scan Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 02/39] MC146818 RTC: coordinate guest clock base to destination host after migration Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 03/39] hw/misc/edu: support MSI interrupt Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 04/39] intc: add an interface to gather statistics/informations on interrupt controllers Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 05/39] intc/i8259: implement InterruptStatsProvider interface Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 06/39] intc/slavio_intctl: " Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 07/39] intc/lm32_pic: " Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 08/39] intc: make HMP 'info irq' and 'info pic' commands use " Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 09/39] intc: make HMP 'info irq' and 'info pic' commands available on all targets Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 10/39] atomic.h: fix __SANITIZE_THREAD__ build Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 11/39] atomic.h: comment on use of atomic_read/set Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 12/39] tcg/optimize: move default return out of if statement Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 13/39] seqlock: use atomic writes for the sequence Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 14/39] qom/object: update class cache atomically Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 15/39] qom/cpu: atomically clear the tb_jmp_cache Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 16/39] cpu: atomically modify cpu->exit_request Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 17/39] util/qht: atomically set b->hashes Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 18/39] linux-user/syscall: extend lock around cpu-list Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 19/39] qga/command: use QEMU atomic primitives Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 20/39] .travis.yml: add gcc sanitizer build Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 21/39] i8259: give ISA device when registering ISA ioports Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 22/39] char: use a fixed idx for child muxed chr Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 23/39] char: update read handler in all cases Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 24/39] util: Introduce qemu_get_pid_name Paolo Bonzini
2016-10-07 16:57 ` Paolo Bonzini [this message]
2016-10-07 16:57 ` [Qemu-devel] [PULL 26/39] qemu-nbd: Shrink image size by specified offset Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 27/39] qht: simplify qht_reset_size Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 28/39] qht: fix unlock-after-free segfault upon resizing Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 29/39] test-qht: perform lookups under rcu_read_lock Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 30/39] qemu-tech: drop index Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 31/39] qemu-doc: replace introduction with the one from the internals manual Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 32/39] qemu-doc: drop installation and compilation notes Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 33/39] qemu-tech: move text from qemu-tech to tcg/README Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 34/39] qemu-tech: document lazy condition code evaluation in cpu.h Paolo Bonzini
2016-10-07 16:57 ` [Qemu-devel] [PULL 35/39] qemu-tech: move user mode emulation features from qemu-tech Paolo Bonzini
2016-10-07 16:58 ` [Qemu-devel] [PULL 36/39] qemu-tech: move TCG test documentation to tests/tcg/README Paolo Bonzini
2016-10-07 16:58 ` [Qemu-devel] [PULL 37/39] qemu-tech: reorganize content Paolo Bonzini
2016-10-07 16:58 ` [Qemu-devel] [PULL 38/39] qemu-tech: rewrite some parts Paolo Bonzini
2016-10-07 16:58 ` [Qemu-devel] [PULL 39/39] qemu-doc: merge qemu-tech and qemu-doc Paolo Bonzini
2016-10-10 10:44 ` [Qemu-devel] [PULL 00/39] Misc patches for 2016-10-07 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475859483-32234-26-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).