From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Liang Li <liang.z.li@intel.com>, Thomas Huth <thuth@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: [Qemu-devel] [PULL 01/33] virtio-balloon: Remove needless precompiled directive
Date: Mon, 10 Oct 2016 05:57:35 +0300 [thread overview]
Message-ID: <1476057841-21108-2-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1476057841-21108-1-git-send-email-mst@redhat.com>
From: Liang Li <liang.z.li@intel.com>
Since there in wrapper around madvise(), the virtio-balloon
code is able to work without the precompiled directive, the
directive can be removed.
Signed-off-by: Liang Li <liang.z.li@intel.com>
Suggested-by: Thomas Huth <thuth@redhat.com>
Reviewd-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio/virtio-balloon.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 49a2f4a..eb572e6 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -34,13 +34,11 @@
static void balloon_page(void *addr, int deflate)
{
-#if defined(__linux__)
if (!qemu_balloon_is_inhibited() && (!kvm_enabled() ||
kvm_has_sync_mmu())) {
qemu_madvise(addr, BALLOON_PAGE_SIZE,
deflate ? QEMU_MADV_WILLNEED : QEMU_MADV_DONTNEED);
}
-#endif
}
static const char *balloon_stat_names[] = {
--
MST
next prev parent reply other threads:[~2016-10-10 2:57 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 2:57 [Qemu-devel] [PULL 00/33] virtio, pc: fixes and features Michael S. Tsirkin
2016-10-10 2:57 ` Michael S. Tsirkin [this message]
2016-10-10 2:57 ` [Qemu-devel] [PULL 02/33] virtio-serial: add plumbing for virtio console emergency write support Michael S. Tsirkin
2016-10-10 2:57 ` [Qemu-devel] [PULL 03/33] virtio-serial: enable virtio console emergency write feature Michael S. Tsirkin
2016-10-10 2:57 ` [Qemu-devel] [PULL 04/33] numa: reduce code duplication by adding helper numa_get_node_for_cpu() Michael S. Tsirkin
2016-10-10 2:57 ` [Qemu-devel] [PULL 05/33] acpi: provide _PXM method for CPU devices if QEMU is started numa enabled Michael S. Tsirkin
2016-10-10 2:57 ` [Qemu-devel] [PULL 06/33] tests: acpi: extend cphp testcase with numa check Michael S. Tsirkin
2016-10-10 2:57 ` [Qemu-devel] [PULL 07/33] tests: acpi tables expected blobs update Michael S. Tsirkin
2016-10-10 2:57 ` [Qemu-devel] [PULL 08/33] virtio: add virtio_detach_element() Michael S. Tsirkin
2016-10-10 2:57 ` [Qemu-devel] [PULL 09/33] virtio-blk: add missing virtio_detach_element() call Michael S. Tsirkin
2016-10-10 2:57 ` [Qemu-devel] [PULL 10/33] virtio-serial: " Michael S. Tsirkin
2016-10-10 2:57 ` [Qemu-devel] [PULL 11/33] virtio-9p: add parentheses to sizeof operator Michael S. Tsirkin
2016-10-10 2:57 ` [Qemu-devel] [PULL 12/33] virtio-blk: make some functions static Michael S. Tsirkin
2016-10-10 2:57 ` [Qemu-devel] [PULL 13/33] virtio-9p: handle handle_9p_output() error Michael S. Tsirkin
2016-10-10 2:57 ` [Qemu-devel] [PULL 14/33] virtio-blk: handle virtio_blk_handle_request() errors Michael S. Tsirkin
2016-10-10 2:57 ` [Qemu-devel] [PULL 15/33] virtio-net: handle virtio_net_handle_ctrl() error Michael S. Tsirkin
2016-10-10 2:57 ` [Qemu-devel] [PULL 16/33] virtio-net: handle virtio_net_receive() errors Michael S. Tsirkin
2016-10-10 2:57 ` [Qemu-devel] [PULL 17/33] virtio-net: handle virtio_net_flush_tx() errors Michael S. Tsirkin
2016-10-10 2:57 ` [Qemu-devel] [PULL 18/33] virtio-scsi: convert virtio_scsi_bad_req() to use virtio_error() Michael S. Tsirkin
2016-10-10 2:58 ` [Qemu-devel] [PULL 19/33] virtio-scsi: handle virtio_scsi_set_config() error Michael S. Tsirkin
2016-10-10 2:58 ` [Qemu-devel] [PULL 20/33] net: don't poke at chardev internal QemuOpts Michael S. Tsirkin
2016-10-10 2:58 ` [Qemu-devel] [PULL 21/33] virtio: prepare change VMSTATE_VIRTIO_DEVICE macro Michael S. Tsirkin
2016-10-10 2:58 ` [Qemu-devel] [PULL 22/33] virtio-blk: convert VMSTATE_VIRTIO_DEVICE Michael S. Tsirkin
2016-10-10 2:58 ` [Qemu-devel] [PULL 23/33] virtio-net: " Michael S. Tsirkin
2016-10-10 2:58 ` [Qemu-devel] [PULL 24/33] virtio-9p: " Michael S. Tsirkin
2016-10-10 2:58 ` [Qemu-devel] [PULL 25/33] virtio-serial: " Michael S. Tsirkin
2016-10-10 2:58 ` [Qemu-devel] [PULL 26/33] virtio-gpu: " Michael S. Tsirkin
2016-10-10 2:58 ` [Qemu-devel] [PULL 27/33] virtio-input: " Michael S. Tsirkin
2016-10-10 2:58 ` [Qemu-devel] [PULL 28/33] virtio-scsi: " Michael S. Tsirkin
2016-10-10 2:58 ` [Qemu-devel] [PULL 29/33] virtio-balloon: " Michael S. Tsirkin
2016-10-10 2:58 ` [Qemu-devel] [PULL 30/33] virtio-rng: " Michael S. Tsirkin
2016-10-10 2:58 ` [Qemu-devel] [PULL 31/33] vhost-vsock: " Michael S. Tsirkin
2016-10-10 2:58 ` [Qemu-devel] [PULL 32/33] virtio: cleanup VMSTATE_VIRTIO_DEVICE Michael S. Tsirkin
2016-10-10 2:58 ` [Qemu-devel] [PULL 33/33] intel-iommu: Check IOAPIC's Trigger Mode against the one in IRTE Michael S. Tsirkin
2016-10-10 14:13 ` [Qemu-devel] [PULL 00/33] virtio, pc: fixes and features Peter Maydell
2016-10-10 18:32 ` Peter Maydell
2016-10-10 19:27 ` Michael S. Tsirkin
2016-10-11 8:27 ` Sascha Silbe
2016-10-11 9:17 ` Peter Maydell
2016-10-11 11:17 ` Thomas Huth
2016-10-11 11:54 ` Sascha Silbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476057841-21108-2-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=dgilbert@redhat.com \
--cc=liang.z.li@intel.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).