From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btZ6I-00016l-Lk for qemu-devel@nongnu.org; Mon, 10 Oct 2016 07:50:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btZ6E-0004Lw-Ao for qemu-devel@nongnu.org; Mon, 10 Oct 2016 07:50:33 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:39314 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btZ6E-0004LK-62 for qemu-devel@nongnu.org; Mon, 10 Oct 2016 07:50:30 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9ABhk0F116263 for ; Mon, 10 Oct 2016 07:50:28 -0400 Received: from e06smtp09.uk.ibm.com (e06smtp09.uk.ibm.com [195.75.94.105]) by mx0b-001b2d01.pphosted.com with ESMTP id 25xte6byad-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 10 Oct 2016 07:50:28 -0400 Received: from localhost by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 10 Oct 2016 12:50:27 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id B650017D8066 for ; Mon, 10 Oct 2016 12:52:32 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9ABoPkj16580724 for ; Mon, 10 Oct 2016 11:50:25 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9ABoOtS006436 for ; Mon, 10 Oct 2016 05:50:24 -0600 Received: from p-imbrenda.boeblingen.de.ibm.com (dyn-9-152-224-35.boeblingen.de.ibm.com [9.152.224.35]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u9ABoOCg006371 (version=TLSv1/SSLv3 cipher=AES256-SHA256 bits=256 verify=NO) for ; Mon, 10 Oct 2016 05:50:24 -0600 From: Claudio Imbrenda Date: Mon, 10 Oct 2016 13:50:23 +0200 In-Reply-To: <1476100224-19760-1-git-send-email-imbrenda@linux.vnet.ibm.com> References: <1476100224-19760-1-git-send-email-imbrenda@linux.vnet.ibm.com> Message-Id: <1476100224-19760-2-git-send-email-imbrenda@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH v1 1/2] gdbstub: Fix single-step List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Commit e0eeb4a21a3ca4b296220ce4449d8acef9de9049 introduced a bug that causes single-step in the gdbstub to not work, at least in kvm. CPUs that are supposed to single-step will instead run normally. This small patch fixes the problem. (tested on s390x) Signed-off-by: Claudio Imbrenda --- kvm-all.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kvm-all.c b/kvm-all.c index efb5fe3..46b8dcd 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -2237,6 +2237,7 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned long reinject_trap) data.dbg.control |= KVM_GUESTDBG_ENABLE | KVM_GUESTDBG_SINGLESTEP; } kvm_arch_update_guest_debug(cpu, &data.dbg); + data.cpu = cpu; run_on_cpu(cpu, kvm_invoke_set_guest_debug, &data); return data.err; -- 1.9.1