From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btf3O-0001o2-0U for qemu-devel@nongnu.org; Mon, 10 Oct 2016 14:11:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btf3J-0003tU-Mh for qemu-devel@nongnu.org; Mon, 10 Oct 2016 14:11:56 -0400 Received: from g4t3427.houston.hpe.com ([15.241.140.73]:7277) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btf3J-0003rV-H2 for qemu-devel@nongnu.org; Mon, 10 Oct 2016 14:11:53 -0400 From: Thomas Hanson Date: Mon, 10 Oct 2016 12:11:17 -0600 Message-Id: <1476123077-35698-5-git-send-email-thomas.hanson@linaro.org> In-Reply-To: <1476123077-35698-1-git-send-email-thomas.hanson@linaro.org> References: <1476123077-35698-1-git-send-email-thomas.hanson@linaro.org> Subject: [Qemu-devel] [PATCH v2 4/4] target-arm: Comments added to identify cases in a switch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, grant.likely@hpe.com, thomas.hanson@linaro.org 3 cases in a switch in disas_exc() require reference to the ARM ARM spec in order to determine what case they're handling. Signed-off-by: Thomas Hanson --- target-arm/translate-a64.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index a1e5f2c..728e929 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -1678,12 +1678,12 @@ static void disas_exc(DisasContext *s, uint32_t insn) * instruction works properly. */ switch (op2_ll) { - case 1: + case 1: /* SVC */ gen_ss_advance(s); gen_exception_insn(s, 0, EXCP_SWI, syn_aa64_svc(imm16), default_exception_el(s)); break; - case 2: + case 2: /* HVC */ if (s->current_el == 0) { unallocated_encoding(s); break; @@ -1696,7 +1696,7 @@ static void disas_exc(DisasContext *s, uint32_t insn) gen_ss_advance(s); gen_exception_insn(s, 0, EXCP_HVC, syn_aa64_hvc(imm16), 2); break; - case 3: + case 3: /* SMC */ if (s->current_el == 0) { unallocated_encoding(s); break; -- 1.9.1