* [Qemu-devel] [PATCH] target-i386: Unset cannot_destroy_with_object_finalize_yet
@ 2016-10-10 19:34 Eduardo Habkost
2016-10-11 11:37 ` Igor Mammedov
0 siblings, 1 reply; 3+ messages in thread
From: Eduardo Habkost @ 2016-10-10 19:34 UTC (permalink / raw)
To: qemu-devel; +Cc: Markus Armbruster, Paolo Bonzini, Richard Henderson
TYPE_X86_CPU now call cpu_exec_init() on realize, so we don't
need to set cannot_destroy_with_object_finalize_yet anymore.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target-i386/cpu.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 1e8127b..33129db 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -3575,11 +3575,6 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data)
cc->cpu_exec_exit = x86_cpu_exec_exit;
dc->cannot_instantiate_with_device_add_yet = false;
- /*
- * Reason: x86_cpu_initfn() calls cpu_exec_init(), which saves the
- * object in cpus -> dangling pointer after final object_unref().
- */
- dc->cannot_destroy_with_object_finalize_yet = true;
}
static const TypeInfo x86_cpu_type_info = {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target-i386: Unset cannot_destroy_with_object_finalize_yet
2016-10-10 19:34 [Qemu-devel] [PATCH] target-i386: Unset cannot_destroy_with_object_finalize_yet Eduardo Habkost
@ 2016-10-11 11:37 ` Igor Mammedov
2016-10-14 14:58 ` Eduardo Habkost
0 siblings, 1 reply; 3+ messages in thread
From: Igor Mammedov @ 2016-10-11 11:37 UTC (permalink / raw)
To: Eduardo Habkost
Cc: qemu-devel, Paolo Bonzini, Markus Armbruster, Richard Henderson
On Mon, 10 Oct 2016 16:34:36 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:
> TYPE_X86_CPU now call cpu_exec_init() on realize, so we don't
> need to set cannot_destroy_with_object_finalize_yet anymore.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> target-i386/cpu.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 1e8127b..33129db 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -3575,11 +3575,6 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data)
> cc->cpu_exec_exit = x86_cpu_exec_exit;
>
> dc->cannot_instantiate_with_device_add_yet = false;
> - /*
> - * Reason: x86_cpu_initfn() calls cpu_exec_init(), which saves the
> - * object in cpus -> dangling pointer after final object_unref().
> - */
> - dc->cannot_destroy_with_object_finalize_yet = true;
> }
>
> static const TypeInfo x86_cpu_type_info = {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target-i386: Unset cannot_destroy_with_object_finalize_yet
2016-10-11 11:37 ` Igor Mammedov
@ 2016-10-14 14:58 ` Eduardo Habkost
0 siblings, 0 replies; 3+ messages in thread
From: Eduardo Habkost @ 2016-10-14 14:58 UTC (permalink / raw)
To: Igor Mammedov
Cc: qemu-devel, Paolo Bonzini, Markus Armbruster, Richard Henderson
On Tue, Oct 11, 2016 at 01:37:07PM +0200, Igor Mammedov wrote:
> On Mon, 10 Oct 2016 16:34:36 -0300
> Eduardo Habkost <ehabkost@redhat.com> wrote:
>
> > TYPE_X86_CPU now call cpu_exec_init() on realize, so we don't
> > need to set cannot_destroy_with_object_finalize_yet anymore.
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Thanks. Applied to x86-next.
--
Eduardo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-14 14:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-10 19:34 [Qemu-devel] [PATCH] target-i386: Unset cannot_destroy_with_object_finalize_yet Eduardo Habkost
2016-10-11 11:37 ` Igor Mammedov
2016-10-14 14:58 ` Eduardo Habkost
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).