From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bttGN-0007QI-VR for qemu-devel@nongnu.org; Tue, 11 Oct 2016 05:22:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bttGJ-000677-PM for qemu-devel@nongnu.org; Tue, 11 Oct 2016 05:22:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bttGJ-00065n-Jt for qemu-devel@nongnu.org; Tue, 11 Oct 2016 05:22:15 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5E5EC73049 for ; Tue, 11 Oct 2016 09:22:14 +0000 (UTC) From: Ladi Prosek Date: Tue, 11 Oct 2016 11:22:02 +0200 Message-Id: <1476177724-28712-1-git-send-email-lprosek@redhat.com> Subject: [Qemu-devel] [PATCH 0/2] virtio: cosmetic tweaks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, mst@redhat.com Just a trivial couple of patches addressing minor style issues. Enforcing the correct order of operations (pop, unpop, push, rewind) with an assert, which was another potential change discussed previously, would add a non-trivial amount of code and is not worth the effort in my opinion. A simple linked-list of VirtQueueElement would not be enough because these are not in the ownership of the common virtio code. The effect of an out-of-order, yet valid, virtqueue_push would need to be encoded in the linked list even though the element has been deallocated. It's almost like maintaining a shadow available ring - doable but not justified at the moment. Ladi Prosek (2): virtio: rename virtqueue_discard to virtqueue_unpop virtio: make virtqueue_alloc_element static