From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buJ78-0003E7-3x for qemu-devel@nongnu.org; Wed, 12 Oct 2016 08:58:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buJ73-0005y3-Oa for qemu-devel@nongnu.org; Wed, 12 Oct 2016 08:58:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56718) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buJ73-0005wv-Ii for qemu-devel@nongnu.org; Wed, 12 Oct 2016 08:58:25 -0400 From: Gerd Hoffmann Date: Wed, 12 Oct 2016 14:58:17 +0200 Message-Id: <1476277098-29570-11-git-send-email-kraxel@redhat.com> In-Reply-To: <1476277098-29570-1-git-send-email-kraxel@redhat.com> References: <1476277098-29570-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 10/11] usb: Fix incorrect default DMA offset. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Vijay Kumar B , Gerd Hoffmann From: Vijay Kumar B The default DMA offset is set to 3. When the property is not set by the consumer, the default causes DMA access to be shifted by 3 bytes. In PXA, this results in incorrect DMA access, leading to error notification in the USB controller driver. A better default would be 0, so that there is no offset, when the consumer does not specify one. Signed-off-by: Vijay Kumar B. Reviewed-by: Deepak S. Message-id: 1475060958-7760-1-git-send-email-vijaykumar@zilogic.com Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ohci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index fa57038..c82a92f 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -2139,7 +2139,7 @@ static const TypeInfo ohci_pci_info = { static Property ohci_sysbus_properties[] = { DEFINE_PROP_UINT32("num-ports", OHCISysBusState, num_ports, 3), - DEFINE_PROP_DMAADDR("dma-offset", OHCISysBusState, dma_offset, 3), + DEFINE_PROP_DMAADDR("dma-offset", OHCISysBusState, dma_offset, 0), DEFINE_PROP_END_OF_LIST(), }; -- 1.8.3.1