qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Hanson <thomas.hanson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, grant.likely@hpe.com, thomas.hanson@linaro.org
Subject: [Qemu-devel] [PATCH v3 4/4] target-arm: Comments added to identify cases in a switch
Date: Wed, 12 Oct 2016 13:50:53 -0600	[thread overview]
Message-ID: <1476301853-15774-5-git-send-email-thomas.hanson@linaro.org> (raw)
In-Reply-To: <1476301853-15774-1-git-send-email-thomas.hanson@linaro.org>

3 cases in a switch in disas_exc() require reference to the
ARM ARM spec in order to determine what case they're handling.

Signed-off-by: Thomas Hanson <thomas.hanson@linaro.org>
---
 target-arm/translate-a64.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
index b4a4b72..eb63e2f 100644
--- a/target-arm/translate-a64.c
+++ b/target-arm/translate-a64.c
@@ -1688,12 +1688,12 @@ static void disas_exc(DisasContext *s, uint32_t insn)
          * instruction works properly.
          */
         switch (op2_ll) {
-        case 1:
+        case 1:                                                     /* SVC */
             gen_ss_advance(s);
             gen_exception_insn(s, 0, EXCP_SWI, syn_aa64_svc(imm16),
                                default_exception_el(s));
             break;
-        case 2:
+        case 2:                                                     /* HVC */
             if (s->current_el == 0) {
                 unallocated_encoding(s);
                 break;
@@ -1706,7 +1706,7 @@ static void disas_exc(DisasContext *s, uint32_t insn)
             gen_ss_advance(s);
             gen_exception_insn(s, 0, EXCP_HVC, syn_aa64_hvc(imm16), 2);
             break;
-        case 3:
+        case 3:                                                     /* SMC */
             if (s->current_el == 0) {
                 unallocated_encoding(s);
                 break;
-- 
1.9.1

  parent reply	other threads:[~2016-10-12 19:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-12 19:50 [Qemu-devel] [PATCH v3 0/4] target-arm: Handle tagged addresses when loading PC Thomas Hanson
2016-10-12 19:50 ` [Qemu-devel] [PATCH v3 1/4] target-arm: Infrastucture changes to enable handling of tagged address loading into PC Thomas Hanson
2016-10-12 19:50 ` [Qemu-devel] [PATCH v3 2/4] target-arm: Code changes to implement overwrite of tag field on PC load Thomas Hanson
2016-10-12 19:50 ` [Qemu-devel] [PATCH v3 3/4] target-arm: Comments to mark location of pending work for 56 bit addresses Thomas Hanson
2016-10-12 19:50 ` Thomas Hanson [this message]
2016-10-13 19:09 ` [Qemu-devel] [PATCH v3 0/4] target-arm: Handle tagged addresses when loading PC Tom Hanson
2016-10-13 21:14   ` Peter Maydell
2016-10-17 17:29 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476301853-15774-5-git-send-email-thomas.hanson@linaro.org \
    --to=thomas.hanson@linaro.org \
    --cc=grant.likely@hpe.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).