* [Qemu-devel] [PATCH] colo-compare: remove unused struct CompareChardevProps and 'props' variable
@ 2016-10-13 6:57 zhanghailiang
2016-10-13 7:11 ` Zhang Chen
2016-10-15 12:52 ` Michael Tokarev
0 siblings, 2 replies; 3+ messages in thread
From: zhanghailiang @ 2016-10-13 6:57 UTC (permalink / raw)
To: qemu-trivial; +Cc: zhangchen.fnst, jasowang, mjt, qemu-devel, zhanghailiang
After commit 0a73336d, 'props' variable in find_and_check_chardev()
is unused. Remove it, togther with struct CompareChardevProps.
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
net/colo-compare.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 47703c5..4be6fc3 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -92,10 +92,6 @@ typedef struct CompareClass {
ObjectClass parent_class;
} CompareClass;
-typedef struct CompareChardevProps {
- bool is_socket;
-} CompareChardevProps;
-
enum {
PRIMARY_IN = 0,
SECONDARY_IN,
@@ -573,8 +569,6 @@ static int find_and_check_chardev(CharDriverState **chr,
char *chr_name,
Error **errp)
{
- CompareChardevProps props;
-
*chr = qemu_chr_find(chr_name);
if (*chr == NULL) {
error_setg(errp, "Device '%s' not found",
@@ -582,8 +576,6 @@ static int find_and_check_chardev(CharDriverState **chr,
return 1;
}
- memset(&props, 0, sizeof(props));
-
if (!qemu_chr_has_feature(*chr, QEMU_CHAR_FEATURE_RECONNECTABLE)) {
error_setg(errp, "chardev \"%s\" is not reconnectable",
chr_name);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] colo-compare: remove unused struct CompareChardevProps and 'props' variable
2016-10-13 6:57 [Qemu-devel] [PATCH] colo-compare: remove unused struct CompareChardevProps and 'props' variable zhanghailiang
@ 2016-10-13 7:11 ` Zhang Chen
2016-10-15 12:52 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Zhang Chen @ 2016-10-13 7:11 UTC (permalink / raw)
To: zhanghailiang, qemu-trivial; +Cc: jasowang, mjt, qemu-devel
On 10/13/2016 02:57 PM, zhanghailiang wrote:
> After commit 0a73336d, 'props' variable in find_and_check_chardev()
> is unused. Remove it, togther with struct CompareChardevProps.
>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Reviewed-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
Thanks
Zhang Chen
> ---
> net/colo-compare.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/net/colo-compare.c b/net/colo-compare.c
> index 47703c5..4be6fc3 100644
> --- a/net/colo-compare.c
> +++ b/net/colo-compare.c
> @@ -92,10 +92,6 @@ typedef struct CompareClass {
> ObjectClass parent_class;
> } CompareClass;
>
> -typedef struct CompareChardevProps {
> - bool is_socket;
> -} CompareChardevProps;
> -
> enum {
> PRIMARY_IN = 0,
> SECONDARY_IN,
> @@ -573,8 +569,6 @@ static int find_and_check_chardev(CharDriverState **chr,
> char *chr_name,
> Error **errp)
> {
> - CompareChardevProps props;
> -
> *chr = qemu_chr_find(chr_name);
> if (*chr == NULL) {
> error_setg(errp, "Device '%s' not found",
> @@ -582,8 +576,6 @@ static int find_and_check_chardev(CharDriverState **chr,
> return 1;
> }
>
> - memset(&props, 0, sizeof(props));
> -
> if (!qemu_chr_has_feature(*chr, QEMU_CHAR_FEATURE_RECONNECTABLE)) {
> error_setg(errp, "chardev \"%s\" is not reconnectable",
> chr_name);
--
Thanks
zhangchen
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] colo-compare: remove unused struct CompareChardevProps and 'props' variable
2016-10-13 6:57 [Qemu-devel] [PATCH] colo-compare: remove unused struct CompareChardevProps and 'props' variable zhanghailiang
2016-10-13 7:11 ` Zhang Chen
@ 2016-10-15 12:52 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2016-10-15 12:52 UTC (permalink / raw)
To: zhanghailiang, qemu-trivial; +Cc: jasowang, qemu-devel, zhangchen.fnst
13.10.2016 09:57, zhanghailiang wrote:
> After commit 0a73336d, 'props' variable in find_and_check_chardev()
> is unused. Remove it, togther with struct CompareChardevProps.
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-15 12:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-13 6:57 [Qemu-devel] [PATCH] colo-compare: remove unused struct CompareChardevProps and 'props' variable zhanghailiang
2016-10-13 7:11 ` Zhang Chen
2016-10-15 12:52 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).