From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buaKb-0002Zl-6L for qemu-devel@nongnu.org; Thu, 13 Oct 2016 03:21:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buaKW-0007pc-O3 for qemu-devel@nongnu.org; Thu, 13 Oct 2016 03:21:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51374) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buaKW-0007pJ-HV for qemu-devel@nongnu.org; Thu, 13 Oct 2016 03:21:28 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 21AC83D95E for ; Thu, 13 Oct 2016 07:21:28 +0000 (UTC) Message-ID: <1476343286.23874.20.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 13 Oct 2016 09:21:26 +0200 In-Reply-To: <1475163940-26094-1-git-send-email-berrange@redhat.com> References: <1475163940-26094-1-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/9] Misc VNC server code cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org On Do, 2016-09-29 at 16:45 +0100, Daniel P. Berrange wrote: > This patches series should have no functional change, it is > just a series of cleanups I've accumulated for the VNC server. > It aims to remove misleading cruft and simplify some parts > to make future work I'm experimenting with easier. >=20 > Daniel P. Berrange (9): > ui: remove misleading comment from vnc_init_state > ui: remove 'enabled' and 'ws_enabled' fields from VncState > ui: remove 'ws_tls' field from VncState > ui: rename misleading 'VncDisplay' variables > ui: refactor method for setting up VncDisplay auth types > ui: remove bogus call to graphic_hw_update() in vnc_listen_io > ui: remove bogus call to reset_keys() in vnc_init_state > ui: move some initialization out of vnc_init_state > ui: rename vnc_init_state to vnc_start_protocol >=20 > ui/vnc-ws.c | 2 +- > ui/vnc.c | 410 +++++++++++++++++++++++++++---------------------------= ------ > ui/vnc.h | 7 +- > 3 files changed, 189 insertions(+), 230 deletions(-) >=20 Added to UI patch queue. thanks, Gerd