From: Stefan Weil <sw@weilnetz.de>
To: QEMU Developer <qemu-devel@nongnu.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Stefan Weil <sw@weilnetz.de>
Subject: [Qemu-devel] [PATCH] Fix build for less common build directories names
Date: Thu, 13 Oct 2016 20:29:30 +0200 [thread overview]
Message-ID: <1476383370-30650-1-git-send-email-sw@weilnetz.de> (raw)
scripts/tracetool generates a C preprocessor macro from the name of the
build directory. Any characters which are possible in a directory name
but not allowed in a macro name must be substituted, otherwise builds
will fail.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
I had problems with a build directory of the form "host,variant".
Is this fix needed for stable, too?
Regards
Stefan W.
scripts/tracetool.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/tracetool.py b/scripts/tracetool.py
index 629b259..fe9c9e9 100755
--- a/scripts/tracetool.py
+++ b/scripts/tracetool.py
@@ -70,7 +70,7 @@ def make_group_name(filename):
if dirname == "":
return "common"
- return re.sub(r"/|-", "_", dirname)
+ return re.sub(r"[^A-Za-z0-9]", "_", dirname)
def main(args):
global _SCRIPT
--
2.1.4
next reply other threads:[~2016-10-13 18:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 18:29 Stefan Weil [this message]
2016-10-13 18:36 ` [Qemu-devel] [PATCH] Fix build for less common build directories names Peter Maydell
2016-10-14 9:53 ` Stefan Hajnoczi
2016-10-14 10:17 ` Paolo Bonzini
2016-10-14 10:01 ` Stefan Hajnoczi
2016-10-14 20:05 ` Stefan Weil
2016-10-16 13:36 ` Stefan Hajnoczi
2016-10-16 14:31 ` Michael Tokarev
2016-10-16 19:04 ` Peter Maydell
2016-10-17 4:43 ` Stefan Weil
2016-10-28 14:57 ` Michael Tokarev
2016-10-28 15:01 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476383370-30650-1-git-send-email-sw@weilnetz.de \
--to=sw@weilnetz.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).