From: Laurent Vivier <lvivier@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgibson@redhat.com, thuth@redhat.com, qemu-ppc@nongnu.org,
Greg Kurz <groug@kaod.org>, Laurent Vivier <lvivier@redhat.com>
Subject: [Qemu-devel] [PATCH v4 2/6] tests: don't check if qtest_spapr_boot() returns NULL
Date: Fri, 14 Oct 2016 10:58:51 +0200 [thread overview]
Message-ID: <1476435535-9408-3-git-send-email-lvivier@redhat.com> (raw)
In-Reply-To: <1476435535-9408-1-git-send-email-lvivier@redhat.com>
qtest_spapr_boot()/qtest_pc_boot()/qtest_boot() call qtest_vboot()
and qtest_vboot() calls g_malloc(),
and g_malloc() never fails:
if memory allocation fails, the application is terminated.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
tests/libqos/libqos.c | 1 +
tests/rtas-test.c | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/libqos/libqos.c b/tests/libqos/libqos.c
index 7abb482..65d6296 100644
--- a/tests/libqos/libqos.c
+++ b/tests/libqos/libqos.c
@@ -10,6 +10,7 @@
/**
* Launch QEMU with the given command line,
* and then set up interrupts and our guest malloc interface.
+ * Never return NULL as the application is terminated if g_malloc() fails.
*/
QOSState *qtest_vboot(QOSOps *ops, const char *cmdline_fmt, va_list ap)
{
diff --git a/tests/rtas-test.c b/tests/rtas-test.c
index ba0867a..276c87e 100644
--- a/tests/rtas-test.c
+++ b/tests/rtas-test.c
@@ -14,7 +14,6 @@ static void test_rtas_get_time_of_day(void)
time_t t1, t2;
qs = qtest_spapr_boot("-machine pseries");
- g_assert(qs != NULL);
t1 = time(NULL);
ret = qrtas_get_time_of_day(qs->alloc, &tm, &ns);
--
2.7.4
next prev parent reply other threads:[~2016-10-14 8:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 8:58 [Qemu-devel] [PATCH v4 0/6] tests: enable virtio tests on SPAPR Laurent Vivier
2016-10-14 8:58 ` [Qemu-devel] [PATCH v4 1/6] tests: fix memory leak in virtio-scsi-test Laurent Vivier
2016-10-14 16:18 ` Greg Kurz
2016-10-14 8:58 ` Laurent Vivier [this message]
2016-10-14 16:46 ` [Qemu-devel] [PATCH v4 2/6] tests: don't check if qtest_spapr_boot() returns NULL Greg Kurz
2016-10-14 8:58 ` [Qemu-devel] [PATCH v4 3/6] tests: move QVirtioBus pointer into QVirtioDevice Laurent Vivier
2016-10-14 22:19 ` Greg Kurz
2016-10-14 8:58 ` [Qemu-devel] [PATCH v4 4/6] tests: rename target_big_endian() as qvirtio_is_big_endian() Laurent Vivier
2016-10-14 21:11 ` Greg Kurz
2016-10-14 8:58 ` [Qemu-devel] [PATCH v4 5/6] tests: use qtest_pc_boot()/qtest_shutdown() in virtio tests Laurent Vivier
2016-10-14 21:20 ` Greg Kurz
2016-10-14 8:58 ` [Qemu-devel] [PATCH v4 6/6] tests: enable virtio tests on SPAPR Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476435535-9408-3-git-send-email-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=dgibson@redhat.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).