From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buyKX-0000Jv-W2 for qemu-devel@nongnu.org; Fri, 14 Oct 2016 04:59:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buyKX-0005aG-04 for qemu-devel@nongnu.org; Fri, 14 Oct 2016 04:59:05 -0400 From: Laurent Vivier Date: Fri, 14 Oct 2016 10:58:51 +0200 Message-Id: <1476435535-9408-3-git-send-email-lvivier@redhat.com> In-Reply-To: <1476435535-9408-1-git-send-email-lvivier@redhat.com> References: <1476435535-9408-1-git-send-email-lvivier@redhat.com> Subject: [Qemu-devel] [PATCH v4 2/6] tests: don't check if qtest_spapr_boot() returns NULL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: dgibson@redhat.com, thuth@redhat.com, qemu-ppc@nongnu.org, Greg Kurz , Laurent Vivier qtest_spapr_boot()/qtest_pc_boot()/qtest_boot() call qtest_vboot() and qtest_vboot() calls g_malloc(), and g_malloc() never fails: if memory allocation fails, the application is terminated. Signed-off-by: Laurent Vivier --- tests/libqos/libqos.c | 1 + tests/rtas-test.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/libqos.c b/tests/libqos/libqos.c index 7abb482..65d6296 100644 --- a/tests/libqos/libqos.c +++ b/tests/libqos/libqos.c @@ -10,6 +10,7 @@ /** * Launch QEMU with the given command line, * and then set up interrupts and our guest malloc interface. + * Never return NULL as the application is terminated if g_malloc() fails. */ QOSState *qtest_vboot(QOSOps *ops, const char *cmdline_fmt, va_list ap) { diff --git a/tests/rtas-test.c b/tests/rtas-test.c index ba0867a..276c87e 100644 --- a/tests/rtas-test.c +++ b/tests/rtas-test.c @@ -14,7 +14,6 @@ static void test_rtas_get_time_of_day(void) time_t t1, t2; qs = qtest_spapr_boot("-machine pseries"); - g_assert(qs != NULL); t1 = time(NULL); ret = qrtas_get_time_of_day(qs->alloc, &tm, &ns); -- 2.7.4