From: Ashijeet Acharya <ashijeetacharya@gmail.com>
To: kwolf@redhat.com
Cc: rjones@redhat.com, jcody@redhat.com, mreitz@redhat.com,
eblake@redhat.com, armbru@redhat.com, berrange@redhat.com,
kraxel@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org,
Ashijeet Acharya <ashijeetacharya@gmail.com>
Subject: [Qemu-devel] [v2 4/5] block/ssh: Use InetSocketAddress options
Date: Sat, 15 Oct 2016 14:34:39 +0530 [thread overview]
Message-ID: <1476522280-23211-5-git-send-email-ashijeetacharya@gmail.com> (raw)
In-Reply-To: <1476522280-23211-1-git-send-email-ashijeetacharya@gmail.com>
Drop the use of legacy options in favour of the InetSocketAddress
options.
Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
---
block/ssh.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index 6420359..7fec0e1 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -199,6 +199,7 @@ static int parse_uri(const char *filename, QDict *options, Error **errp)
{
URI *uri = NULL;
QueryParams *qp;
+ char *port_str;
int i;
uri = uri_parse(filename);
@@ -231,11 +232,10 @@ static int parse_uri(const char *filename, QDict *options, Error **errp)
qdict_put(options, "user", qstring_from_str(uri->user));
}
- qdict_put(options, "host", qstring_from_str(uri->server));
+ qdict_put(options, "server.host", qstring_from_str(uri->server));
- if (uri->port) {
- qdict_put(options, "port", qint_from_int(uri->port));
- }
+ port_str = g_strdup_printf("%d", uri->port ?: 22);
+ qdict_put(options, "server.port", qstring_from_str(port_str));
qdict_put(options, "path", qstring_from_str(uri->path));
@@ -251,6 +251,7 @@ static int parse_uri(const char *filename, QDict *options, Error **errp)
query_params_free(qp);
uri_free(uri);
+ g_free(port_str);
return 0;
err:
--
2.6.2
next prev parent reply other threads:[~2016-10-15 9:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-15 9:04 [Qemu-devel] [v2 0/5] Allow blockdev-add for SSH Ashijeet Acharya
2016-10-15 9:04 ` [Qemu-devel] [v2 1/5] block/ssh: Add ssh_has_filename_options_conflict() Ashijeet Acharya
2016-10-15 21:28 ` Max Reitz
2016-10-15 9:04 ` [Qemu-devel] [v2 2/5] block/ssh: Add InetSocketAddress and accept it Ashijeet Acharya
2016-10-15 22:30 ` Max Reitz
2016-10-16 8:53 ` Ashijeet Acharya
2016-10-16 9:10 ` Ashijeet Acharya
2016-10-17 11:27 ` Kevin Wolf
2016-10-17 12:33 ` Ashijeet Acharya
2016-10-17 12:57 ` Kevin Wolf
2016-10-17 15:44 ` Ashijeet Acharya
2016-10-17 15:53 ` Kevin Wolf
2016-10-17 15:56 ` Ashijeet Acharya
2016-10-17 15:59 ` Eric Blake
2016-10-17 16:08 ` Ashijeet Acharya
2016-10-15 9:04 ` [Qemu-devel] [v2 3/5] block/ssh: Use inet_connect_saddr() to establish socket connection Ashijeet Acharya
2016-10-15 22:34 ` Max Reitz
2016-10-15 9:04 ` Ashijeet Acharya [this message]
2016-10-15 22:37 ` [Qemu-devel] [v2 4/5] block/ssh: Use InetSocketAddress options Max Reitz
2016-10-15 9:04 ` [Qemu-devel] [v2 5/5] qapi: allow blockdev-add for ssh Ashijeet Acharya
2016-10-15 22:43 ` Max Reitz
2016-10-15 9:25 ` [Qemu-devel] [v2 0/5] Allow blockdev-add for SSH no-reply
2016-10-17 11:29 ` Kevin Wolf
2016-10-17 12:33 ` Ashijeet Acharya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476522280-23211-5-git-send-email-ashijeetacharya@gmail.com \
--to=ashijeetacharya@gmail.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).