From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
qemu-devel@nongnu.org, "Radim Krčmář" <rkrcmar@redhat.com>
Subject: [Qemu-devel] [PULL 17/21] target-i386/kvm: cache the return value of kvm_enable_x2apic()
Date: Mon, 17 Oct 2016 15:51:34 -0200 [thread overview]
Message-ID: <1476726698-14661-18-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1476726698-14661-1-git-send-email-ehabkost@redhat.com>
From: Radim Krčmář <rkrcmar@redhat.com>
Assume that KVM would have returned the same on subsequent runs.
Abstract the memoizaiton pattern into macros and call it memorize as
adding the r makes it less obscure.
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target-i386/kvm.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 0fd6646..0472f45 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -129,10 +129,23 @@ static bool kvm_x2apic_api_set_flags(uint64_t flags)
return !kvm_vm_enable_cap(s, KVM_CAP_X2APIC_API, 0, flags);
}
+#define MEMORIZE(fn) \
+ ({ \
+ static typeof(fn) _result; \
+ static bool _memorized; \
+ \
+ if (_memorized) { \
+ return _result; \
+ } \
+ _memorized = true; \
+ _result = fn; \
+ })
+
bool kvm_enable_x2apic(void)
{
- return kvm_x2apic_api_set_flags(KVM_X2APIC_API_USE_32BIT_IDS |
- KVM_X2APIC_API_DISABLE_BROADCAST_QUIRK);
+ return MEMORIZE(
+ kvm_x2apic_api_set_flags(KVM_X2APIC_API_USE_32BIT_IDS |
+ KVM_X2APIC_API_DISABLE_BROADCAST_QUIRK));
}
static int kvm_get_tsc(CPUState *cs)
--
2.7.4
next prev parent reply other threads:[~2016-10-17 17:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 17:51 [Qemu-devel] [PULL 00/21] x86 queue, 2016-10-17 Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 01/21] tests: Add test case for x86 feature parsing compatibility Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 02/21] target-i386: List CPU models using subclass list Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 03/21] target-i386: Disable VME by default with TCG Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 04/21] target-i386: Register aliases for feature names with underscores Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 05/21] target-i386: Make plus_features/minus_features QOM-based Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 06/21] target-i386: Remove underscores from feat_names arrays Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 07/21] target-i386: Register properties for feature aliases manually Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 08/21] target-i386: xsave: Add FP and SSE bits to x86_ext_save_areas Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 09/21] qmp: Add runnability information to query-cpu-definitions Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 10/21] target-i386: Move warning code outside x86_cpu_filter_features() Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 11/21] apic: add global apic_get_class() Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 12/21] apic: add send_msi() to APICCommonClass Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 13/21] intel_iommu: pass whole remapped addresses to apic Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 14/21] intel_iommu: redo configuraton check in realize Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 15/21] intel_iommu: add OnOffAuto intr_eim as "eim" property Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 16/21] intel_iommu: reject broken EIM Eduardo Habkost
2016-10-17 17:51 ` Eduardo Habkost [this message]
2016-10-17 17:51 ` [Qemu-devel] [PULL 18/21] target-i386: Unset cannot_destroy_with_object_finalize_yet Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 19/21] target-i386: x86_cpu_load_features() function Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 20/21] target-i386: Return runnability information on query-cpu-definitions Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 21/21] target-i386: Don't use cpu->migratable when filtering features Eduardo Habkost
2016-10-18 9:33 ` [Qemu-devel] [PULL 00/21] x86 queue, 2016-10-17 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476726698-14661-18-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).