From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 18/21] target-i386: Unset cannot_destroy_with_object_finalize_yet
Date: Mon, 17 Oct 2016 15:51:35 -0200 [thread overview]
Message-ID: <1476726698-14661-19-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1476726698-14661-1-git-send-email-ehabkost@redhat.com>
TYPE_X86_CPU now call cpu_exec_init() on realize, so we don't
need to set cannot_destroy_with_object_finalize_yet anymore.
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target-i386/cpu.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 5b3ad78..1372419 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -3582,11 +3582,6 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data)
cc->cpu_exec_exit = x86_cpu_exec_exit;
dc->cannot_instantiate_with_device_add_yet = false;
- /*
- * Reason: x86_cpu_initfn() calls cpu_exec_init(), which saves the
- * object in cpus -> dangling pointer after final object_unref().
- */
- dc->cannot_destroy_with_object_finalize_yet = true;
}
static const TypeInfo x86_cpu_type_info = {
--
2.7.4
next prev parent reply other threads:[~2016-10-17 17:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 17:51 [Qemu-devel] [PULL 00/21] x86 queue, 2016-10-17 Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 01/21] tests: Add test case for x86 feature parsing compatibility Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 02/21] target-i386: List CPU models using subclass list Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 03/21] target-i386: Disable VME by default with TCG Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 04/21] target-i386: Register aliases for feature names with underscores Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 05/21] target-i386: Make plus_features/minus_features QOM-based Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 06/21] target-i386: Remove underscores from feat_names arrays Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 07/21] target-i386: Register properties for feature aliases manually Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 08/21] target-i386: xsave: Add FP and SSE bits to x86_ext_save_areas Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 09/21] qmp: Add runnability information to query-cpu-definitions Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 10/21] target-i386: Move warning code outside x86_cpu_filter_features() Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 11/21] apic: add global apic_get_class() Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 12/21] apic: add send_msi() to APICCommonClass Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 13/21] intel_iommu: pass whole remapped addresses to apic Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 14/21] intel_iommu: redo configuraton check in realize Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 15/21] intel_iommu: add OnOffAuto intr_eim as "eim" property Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 16/21] intel_iommu: reject broken EIM Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 17/21] target-i386/kvm: cache the return value of kvm_enable_x2apic() Eduardo Habkost
2016-10-17 17:51 ` Eduardo Habkost [this message]
2016-10-17 17:51 ` [Qemu-devel] [PULL 19/21] target-i386: x86_cpu_load_features() function Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 20/21] target-i386: Return runnability information on query-cpu-definitions Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 21/21] target-i386: Don't use cpu->migratable when filtering features Eduardo Habkost
2016-10-18 9:33 ` [Qemu-devel] [PULL 00/21] x86 queue, 2016-10-17 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476726698-14661-19-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).