From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwC5G-00018W-H9 for qemu-devel@nongnu.org; Mon, 17 Oct 2016 13:52:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwC5F-0002u2-Tc for qemu-devel@nongnu.org; Mon, 17 Oct 2016 13:52:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41328) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwC5F-0002to-Nf for qemu-devel@nongnu.org; Mon, 17 Oct 2016 13:52:21 -0400 From: Eduardo Habkost Date: Mon, 17 Oct 2016 15:51:35 -0200 Message-Id: <1476726698-14661-19-git-send-email-ehabkost@redhat.com> In-Reply-To: <1476726698-14661-1-git-send-email-ehabkost@redhat.com> References: <1476726698-14661-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PULL 18/21] target-i386: Unset cannot_destroy_with_object_finalize_yet List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , Richard Henderson , qemu-devel@nongnu.org TYPE_X86_CPU now call cpu_exec_init() on realize, so we don't need to set cannot_destroy_with_object_finalize_yet anymore. Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 5b3ad78..1372419 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -3582,11 +3582,6 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data) cc->cpu_exec_exit = x86_cpu_exec_exit; dc->cannot_instantiate_with_device_add_yet = false; - /* - * Reason: x86_cpu_initfn() calls cpu_exec_init(), which saves the - * object in cpus -> dangling pointer after final object_unref(). - */ - dc->cannot_destroy_with_object_finalize_yet = true; } static const TypeInfo x86_cpu_type_info = { -- 2.7.4