qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 04/21] target-i386: Register aliases for feature names with underscores
Date: Mon, 17 Oct 2016 15:51:21 -0200	[thread overview]
Message-ID: <1476726698-14661-5-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1476726698-14661-1-git-send-email-ehabkost@redhat.com>

Registering the actual names containing underscores as aliases
will allow management software to be aware that the old
compatibility names are suported, and will make feat2prop() calls
unnecessary when using feature names.

Also, this will help us avoid making the code support underscores
on feature names that never had them in the first place. e.g.
"+tsc_deadline" was never supported and doesn't need to be
translated to "+tsc-deadline".

In other word: this will require less magic translation of
strings, and simple 1:1 match between the config options and
actual QOM properties.

Note that the underscores are still present in the
FeatureWordInfo::feat_names arrays, because
add_flagname_to_bitmaps() needs them to be kept. The next patches
will remove add_flagname_to_bitmaps() and will allow us to
finally remove the aliases from feat_names.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target-i386/cpu.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 25a3d80..fe62ae1 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -3455,6 +3455,28 @@ static void x86_cpu_initfn(Object *obj)
         }
     }
 
+    object_property_add_alias(obj, "ds_cpl", obj, "ds-cpl", &error_abort);
+    object_property_add_alias(obj, "tsc_adjust", obj, "tsc-adjust", &error_abort);
+    object_property_add_alias(obj, "fxsr_opt", obj, "fxsr-opt", &error_abort);
+    object_property_add_alias(obj, "lahf_lm", obj, "lahf-lm", &error_abort);
+    object_property_add_alias(obj, "cmp_legacy", obj, "cmp-legacy", &error_abort);
+    object_property_add_alias(obj, "nodeid_msr", obj, "nodeid-msr", &error_abort);
+    object_property_add_alias(obj, "perfctr_core", obj, "perfctr-core", &error_abort);
+    object_property_add_alias(obj, "perfctr_nb", obj, "perfctr-nb", &error_abort);
+    object_property_add_alias(obj, "kvm_nopiodelay", obj, "kvm-nopiodelay", &error_abort);
+    object_property_add_alias(obj, "kvm_mmu", obj, "kvm-mmu", &error_abort);
+    object_property_add_alias(obj, "kvm_asyncpf", obj, "kvm-asyncpf", &error_abort);
+    object_property_add_alias(obj, "kvm_steal_time", obj, "kvm-steal-time", &error_abort);
+    object_property_add_alias(obj, "kvm_pv_eoi", obj, "kvm-pv-eoi", &error_abort);
+    object_property_add_alias(obj, "kvm_pv_unhalt", obj, "kvm-pv-unhalt", &error_abort);
+    object_property_add_alias(obj, "svm_lock", obj, "svm-lock", &error_abort);
+    object_property_add_alias(obj, "nrip_save", obj, "nrip-save", &error_abort);
+    object_property_add_alias(obj, "tsc_scale", obj, "tsc-scale", &error_abort);
+    object_property_add_alias(obj, "vmcb_clean", obj, "vmcb-clean", &error_abort);
+    object_property_add_alias(obj, "pause_filter", obj, "pause-filter", &error_abort);
+    object_property_add_alias(obj, "sse4_1", obj, "sse4.1", &error_abort);
+    object_property_add_alias(obj, "sse4_2", obj, "sse4.2", &error_abort);
+
     x86_cpu_load_def(cpu, xcc->cpu_def, &error_abort);
 }
 
-- 
2.7.4

  parent reply	other threads:[~2016-10-17 17:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 17:51 [Qemu-devel] [PULL 00/21] x86 queue, 2016-10-17 Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 01/21] tests: Add test case for x86 feature parsing compatibility Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 02/21] target-i386: List CPU models using subclass list Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 03/21] target-i386: Disable VME by default with TCG Eduardo Habkost
2016-10-17 17:51 ` Eduardo Habkost [this message]
2016-10-17 17:51 ` [Qemu-devel] [PULL 05/21] target-i386: Make plus_features/minus_features QOM-based Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 06/21] target-i386: Remove underscores from feat_names arrays Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 07/21] target-i386: Register properties for feature aliases manually Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 08/21] target-i386: xsave: Add FP and SSE bits to x86_ext_save_areas Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 09/21] qmp: Add runnability information to query-cpu-definitions Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 10/21] target-i386: Move warning code outside x86_cpu_filter_features() Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 11/21] apic: add global apic_get_class() Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 12/21] apic: add send_msi() to APICCommonClass Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 13/21] intel_iommu: pass whole remapped addresses to apic Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 14/21] intel_iommu: redo configuraton check in realize Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 15/21] intel_iommu: add OnOffAuto intr_eim as "eim" property Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 16/21] intel_iommu: reject broken EIM Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 17/21] target-i386/kvm: cache the return value of kvm_enable_x2apic() Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 18/21] target-i386: Unset cannot_destroy_with_object_finalize_yet Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 19/21] target-i386: x86_cpu_load_features() function Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 20/21] target-i386: Return runnability information on query-cpu-definitions Eduardo Habkost
2016-10-17 17:51 ` [Qemu-devel] [PULL 21/21] target-i386: Don't use cpu->migratable when filtering features Eduardo Habkost
2016-10-18  9:33 ` [Qemu-devel] [PULL 00/21] x86 queue, 2016-10-17 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476726698-14661-5-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).